Skip to content

Optimize GetPooledTransactionsFromPeerTask with HashSet #6071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macfarla merged 2 commits into from
Oct 25, 2023
Merged

Optimize GetPooledTransactionsFromPeerTask with HashSet #6071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7beee1f
Optimize GetPooledTransactionsFromPeerTask with HashSet
7suyash7 Oct 22, 2023
f6a1f7f
Merge branch 'main' into getpooltx
macfarla Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...ava/org/hyperledger/besu/ethereum/eth/manager/task/GetPooledTransactionsFromPeerTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@
import org.hyperledger.besu.plugin.services.MetricsSystem;

import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Optional;
import java.util.Set;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand All @@ -38,20 +40,20 @@ public class GetPooledTransactionsFromPeerTask extends AbstractPeerRequestTask<L
private static final Logger LOG =
LoggerFactory.getLogger(GetPooledTransactionsFromPeerTask.class);

private final List<Hash> hashes;
private final Set<Hash> hashes;

private GetPooledTransactionsFromPeerTask(
final EthContext ethContext, final List<Hash> hashes, final MetricsSystem metricsSystem) {
super(ethContext, EthPV65.GET_POOLED_TRANSACTIONS, metricsSystem);
this.hashes = List.copyOf(hashes);
this.hashes = new HashSet<>(hashes);
}

public static GetPooledTransactionsFromPeerTask forHashes(
final EthContext ethContext, final List<Hash> hashes, final MetricsSystem metricsSystem) {
return new GetPooledTransactionsFromPeerTask(ethContext, hashes, metricsSystem);
}

public List<Hash> getTransactionHashes() {
public Set<Hash> getTransactionHashes() {
return hashes;
}

Expand All @@ -60,7 +62,7 @@ protected PendingPeerRequest sendRequest() {
return sendRequestToPeer(
peer -> {
LOG.debug("Requesting {} transaction pool entries from peer {}.", hashes.size(), peer);
return peer.getPooledTransactions(hashes);
return peer.getPooledTransactions(new ArrayList<>(hashes));
},
0);
}
Expand Down