Skip to content

implements tx sizing for blob txs #6014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jflo wants to merge 2 commits into from
Closed

implements tx sizing for blob txs #6014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
228c433
implements tx sizing for blob txs
jflo Oct 10, 2023
b65f2b6
removes cast
jflo Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions datatypes/src/main/java/org/hyperledger/besu/datatypes/BlobsWithCommitments.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,11 @@ public List<KZGProof> getKzgProofs() {
public List<VersionedHash> getVersionedHashes() {
return versionedHashes;
}

public int getByteCount() {
int blobSize = blobs.stream().mapToInt(b -> b.getData().size()).sum();
int commitmentSize = kzgCommitments.stream().mapToInt(c -> c.getData().size()).sum();
int proofSize = kzgProofs.stream().mapToInt(p -> p.getData().size()).sum();
return blobSize + commitmentSize + proofSize;
}
}
6 changes: 4 additions & 2 deletions .../eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/PendingTransaction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import org.hyperledger.besu.datatypes.AccessListEntry;
import org.hyperledger.besu.datatypes.Address;
import org.hyperledger.besu.datatypes.BlobsWithCommitments;
import org.hyperledger.besu.datatypes.Hash;
import org.hyperledger.besu.datatypes.Wei;
import org.hyperledger.besu.ethereum.core.Transaction;
Expand Down Expand Up @@ -119,8 +120,9 @@ private int computeEIP1559MemorySize() {
}

private int computeBlobMemorySize() {
// ToDo 4844: adapt for blobs
return computeEIP1559MemorySize();
int blobsSize =
transaction.getBlobsWithCommitments().map(BlobsWithCommitments::getByteCount).orElse(0);
return computeEIP1559MemorySize() + blobsSize;
}

private int computePayloadMemorySize() {
Expand Down