Skip to content

[MINOR] Expose getSize to transaction interface #5983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabriel-Trintinalia merged 1 commit into from
Oct 4, 2023
Merged

[MINOR] Expose getSize to transaction interface #5983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions datatypes/src/main/java/org/hyperledger/besu/datatypes/Transaction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,4 +219,11 @@ default Optional<? extends Quantity> getMaxFeePerBlobGas() {
* @return the encoded transaction as Bytes
*/
Bytes encoded();

/**
* Returns the size in bytes of the encoded transaction.
*
* @return the size in bytes of the encoded transaction.
*/
int getSize();
}
1 change: 1 addition & 0 deletions ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,7 @@ public Hash getHash() {
*
* @return the size in bytes of the encoded transaction.
*/
@Override
public int getSize() {
if (size == -1) {
memoizeHashAndSize();
Expand Down