Skip to content

Forkchoice v2 hive tests#5949

Merged
Gabriel-Trintinalia merged 3 commits intohyperledger:mainfrom
jflo:forkchoiceV2_hiveTests
Sep 27, 2023
Merged

Forkchoice v2 hive tests#5949
Gabriel-Trintinalia merged 3 commits intohyperledger:mainfrom
jflo:forkchoiceV2_hiveTests

Conversation

@jflo
Copy link
Contributor

@jflo jflo commented Sep 26, 2023

re-arranges validations so the failures occurr when hive expects them to.

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 41e829b into hyperledger:main Sep 27, 2023
jflo added a commit to jflo/besu that referenced this pull request Nov 10, 2023
* payload validation moved earlier, fcu v2 checks for cancun timestamps

Signed-off-by: Justin Florentine <justin+github@florentine.us>

* payload validation moved earlier, fcu v2 checks for cancun timestamps

Signed-off-by: Justin Florentine <justin+github@florentine.us>

* build passes

Signed-off-by: Justin Florentine <justin+github@florentine.us>

---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
* payload validation moved earlier, fcu v2 checks for cancun timestamps

Signed-off-by: Justin Florentine <justin+github@florentine.us>

* payload validation moved earlier, fcu v2 checks for cancun timestamps

Signed-off-by: Justin Florentine <justin+github@florentine.us>

* build passes

Signed-off-by: Justin Florentine <justin+github@florentine.us>

---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants