Transaction pool unit tests refactoring to remove duplicated code#5948
Merged
fab-10 merged 3 commits intohyperledger:mainfrom Sep 27, 2023
Merged
Transaction pool unit tests refactoring to remove duplicated code#5948fab-10 merged 3 commits intohyperledger:mainfrom
fab-10 merged 3 commits intohyperledger:mainfrom
Conversation
fab-10
changed the title
|
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
txpool-test-refactor
branch
from
583c5b9 to
f4e04a2
Compare
macfarla
approved these changes
Sep 26, 2023
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 10, 2023
…ledger#5948) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
NickSneo
pushed a commit
to NickSneo/besu
that referenced
this pull request
Nov 12, 2023
…ledger#5948) Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Refactor transaction pool tests to remove all the duplicated code that was introduced when implementing the layered txpool.
Now all tests are defined in
AbstractTransactionPoolTestand extending classes are used to setup the right env for fee market and txpool implementation.This make the tests more future proof, since in this way a new test is run against all the implementations and fee markets, while before you had to remember to code the test twice.