Merged
Conversation
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
|
garyschulte
reviewed
Sep 22, 2023
| final Hash worldStateRoot, | ||
| final Address accountAddress, | ||
| final List<UInt256> accountStorageKeys) { | ||
| return worldStateProof.getAccountProof(worldStateRoot, accountAddress, accountStorageKeys); |
Contributor
There was a problem hiding this comment.
should we use this.worldStateRootHash instead? passing the state root makes sense for forest, but not really for bonsai.
Contributor
Author
There was a problem hiding this comment.
you right I modified the code, I moved the getProof to archive again with some modification. it will normally makes sense now . if you can review again
garyschulte
reviewed
Sep 22, 2023
| public static Object[][] specs() { | ||
| return findSpecFiles( | ||
| new String[] {"eth"}, "getProof"); // getProof is not working with bonsai trie | ||
| return findSpecFiles(new String[] {"eth"}); |
garyschulte
approved these changes
Sep 22, 2023
Contributor
garyschulte
left a comment
garyschulte
left a comment
There was a problem hiding this comment.
LGTM. non-blocking question regarding arbitrary state root in bonsai. Otherwise 🚢
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
shemnon
approved these changes
Sep 22, 2023
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 10, 2023
* add get proof for bonsai Signed-off-by: Karim TAAM <karim.t2am@gmail.com> * fix review Signed-off-by: Karim TAAM <karim.t2am@gmail.com> * remove logs Signed-off-by: Karim TAAM <karim.t2am@gmail.com> --------- Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
NickSneo
pushed a commit
to NickSneo/besu
that referenced
this pull request
Nov 12, 2023
* add get proof for bonsai Signed-off-by: Karim TAAM <karim.t2am@gmail.com> * fix review Signed-off-by: Karim TAAM <karim.t2am@gmail.com> * remove logs Signed-off-by: Karim TAAM <karim.t2am@gmail.com> --------- Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
PR that adds getproof for Bonsai. With this implementation, we can serve the getproof for historical states and not just the head.
Fixed Issue(s)
fixes #5874