fix geth rlpx ping command#5917
Merged
macfarla merged 3 commits intohyperledger:mainfrom Sep 22, 2023
Merged
Conversation
Signed-off-by: Stefan <stefan.pingel@consensys.net>
|
daniellehrner
previously requested changes
Sep 21, 2023
Contributor
daniellehrner
left a comment
daniellehrner
left a comment
There was a problem hiding this comment.
Looks good to me. The only thing that need to be reverted is the update of the reference tests.
Contributor
There was a problem hiding this comment.
It seems the reference tests have been updated by accident.
Signed-off-by: Stefan <stefan.pingel@consensys.net>
macfarla
dismissed
daniellehrner’s stale review
reference tests submodule version fixed
macfarla
approved these changes
Sep 22, 2023
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 10, 2023
* fix geth rlpx ping command Signed-off-by: Stefan <stefan.pingel@consensys.net> --------- Signed-off-by: Stefan <stefan.pingel@consensys.net> Signed-off-by: Justin Florentine <justin+github@florentine.us>
NickSneo
pushed a commit
to NickSneo/besu
that referenced
this pull request
Nov 12, 2023
* fix geth rlpx ping command Signed-off-by: Stefan <stefan.pingel@consensys.net> --------- Signed-off-by: Stefan <stefan.pingel@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
The geth cmd
./build/bin/devp2p rlpx ping enodeAddress
expects the client with address enodeAddress to respond with a HelloMessage right after successfully receiving the handshake message from the initiator.
Existing behaviour in Besu is to wait for the HelloMessage from the initiator before sending the HelloMessage back.