Update reference tests to 12.4#5899
Merged
macfarla merged 4 commits intohyperledger:mainfrom Sep 21, 2023
Merged
Conversation
Update reference tests to 12.4 * Some in-memory storage changed to ConcurrentMap * exclude cancun from all EIP tests, EIP-4788 still in flux * Add new fields to ReferenceTestEnv, and re-order the reflected constructor for clarity and ease of development. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public ReferenceTestEnv( | ||
| @JsonProperty("beaconRoot") final String beaconRoot, | ||
| @JsonProperty("blockHashes") final Map<String, String> blockHashes, | ||
| @JsonProperty("ommers") final List<String> _ommers, |
Check notice
Code scanning / CodeQL
Useless parameter
| @JsonProperty("parentGasLimit") final String parentGasLimit, | ||
| @JsonProperty("parentGasUsed") final String parentGasUsed, | ||
| @JsonProperty("parentTimestamp") final String parentTimestamp, | ||
| @JsonProperty("parentUncleHash") final String _parentUncleHash) { |
Check notice
Code scanning / CodeQL
Useless parameter
matkt
approved these changes
Sep 20, 2023
Contributor
matkt
left a comment
matkt
left a comment
There was a problem hiding this comment.
I don't know why I decided not to put a concurrenthashmap. anyway it's good for me
macfarla
approved these changes
Sep 20, 2023
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 10, 2023
* Update reference tests to 12.4 Update reference tests to 12.4 * Some in-memory storage changed to ConcurrentMap * exclude cancun from all EIP tests, EIP-4788 still in flux * Add new fields to ReferenceTestEnv, and re-order the reflected constructor for clarity and ease of development. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> * spotless Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> --------- Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
NickSneo
pushed a commit
to NickSneo/besu
that referenced
this pull request
Nov 12, 2023
* Update reference tests to 12.4 Update reference tests to 12.4 * Some in-memory storage changed to ConcurrentMap * exclude cancun from all EIP tests, EIP-4788 still in flux * Add new fields to ReferenceTestEnv, and re-order the reflected constructor for clarity and ease of development. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> * spotless Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> --------- Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Update reference tests to 12.4
Fixed Issue(s)
includes speculative changes for #5898 concurrency issue.
services/kvstore/...can be dropped out if there are other fixes, but transient failures result in blockchain and general state tests when removed