Skip to content

adds Matthew Whitehead as a maintainer#5876

Merged
macfarla merged 9 commits intohyperledger:mainfrom
jflo:mattWhiteheadMaintainer
Sep 26, 2023
Merged

adds Matthew Whitehead as a maintainer#5876
macfarla merged 9 commits intohyperledger:mainfrom
jflo:mattWhiteheadMaintainer

Conversation

@jflo
Copy link
Contributor

@jflo jflo commented Sep 13, 2023

I propose to add @matthew1001 as a Besu project maintainer.

@matthew1001 contributed with many high quality commits:

  • has implemented new JSON-RPC api endpoints, per execution api specs
  • has improved error reporting in apis
  • has improved configurability for non PoS networks

Here are their past contributions on Besu project.

Voting ends two weeks from today.

For more information on this process see the Becoming a Maintainer section in the MAINTAINERS.md file.

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
@jflo jflo marked this pull request as ready for review September 13, 2023 17:21
@github-actions
Copy link

github-actions bot commented Sep 13, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contributions @matthew1001 !

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

(nbd, but I think the new entry maybe should go underneath macfarla?)

@macfarla
Copy link
Contributor

🎉

(nbd, but I think the new entry maybe should go underneath macfarla?)

good catch - that's why we need 12 approvals on these PRs... and actually now that I have my fine-toothed comb out - alphabetically - should be below matkt

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@macfarla macfarla enabled auto-merge (squash) September 26, 2023 00:52
@macfarla macfarla merged commit d7a831e into hyperledger:main Sep 26, 2023
jflo added a commit to jflo/besu that referenced this pull request Nov 10, 2023
* adds Matthew Whitehead as a maintainer

* alphabetizes list by github id

Signed-off-by: Justin Florentine <justin+github@florentine.us>

---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
* adds Matthew Whitehead as a maintainer

* alphabetizes list by github id

Signed-off-by: Justin Florentine <justin+github@florentine.us>

---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.