Skip to content

payload attributes: fix wrong warning and fail if beacon root is available before cancun #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macfarla merged 3 commits into from
Sep 13, 2023
Merged

payload attributes: fix wrong warning and fail if beacon root is available before cancun #5872

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1d49be
payload attributes: fix wrong warning and fail if beacon root is avai…
pinges Sep 13, 2023
fe4169a
Merge branch 'main' into FixWrongWarningEnginePayloadParams
macfarla Sep 13, 2023
79cdae2
formatting
macfarla Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...er/besu/ethereum/api/jsonrpc/internal/methods/engine/AbstractEngineForkchoiceUpdated.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,14 @@ private boolean isPayloadAttributesValid(
return false;
}
if (payloadAttributes.getTimestamp() < cancunTimestamp) {
LOG.warn("Payload attributes are present before cancun hardfork");
if (payloadAttributes.getParentBeaconBlockRoot() != null) {
LOG.error(
"Parent beacon block root hash present in payload attributes before cancun hardfork");
return false;
}
} else if (payloadAttributes.getParentBeaconBlockRoot() == null) {
LOG.warn("Parent beacon block root not present in payload attributes after cancun hardfork");
LOG.error(
"Parent beacon block root hash not present in payload attributes after cancun hardfork");
return false;
}
if (!getWithdrawalsValidator(
Expand Down