Skip to content

Force the use of jdk8+ version of Bouncy Castle library#5748

Merged
fab-10 merged 2 commits intohyperledger:mainfrom
fab-10:bouncy-castle-force-jdk18
Oct 12, 2023
Merged

Force the use of jdk8+ version of Bouncy Castle library#5748
fab-10 merged 2 commits intohyperledger:mainfrom
fab-10:bouncy-castle-force-jdk18

Conversation

@fab-10
Copy link
Contributor

@fab-10 fab-10 commented Aug 3, 2023

PR description

This avoid that any dependency can include the jdk5 version in the distribution.

Implement the solution described here https://docs.gradle.org/7.6/userguide/dependency_capability_conflict.html

Had to inline the xor function since it is now deprecated in newer versions of Bouncy Castle.

Fixed Issue(s)

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@fab-10 fab-10 force-pushed the bouncy-castle-force-jdk18 branch from fd79db0 to 95078ab Compare August 3, 2023 14:37
@fab-10 fab-10 marked this pull request as ready for review August 3, 2023 14:58
@fab-10 fab-10 marked this pull request as draft August 3, 2023 17:27
This avoid that any dependency can include the jdk15 version in the distribution.
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the bouncy-castle-force-jdk18 branch from 95078ab to a77b09a Compare October 4, 2023 13:23
@fab-10
Copy link
Contributor Author

fab-10 commented Oct 4, 2023

@ahamlat did some new test with the last version of Bouncy Castle on a Standard_D4s_v5 instance, and I found that the differences between the distribution are very small, as a side node running on newer jdk gives a performance boost.
Could you validate the results?

Bouncy Castle 1.76

jdk15t018 (java19)

Benchmark                    (SIZE)  Mode  Cnt    Score   Error  Units
KeccakBench.benchmarkKeccak      32  avgt   50  540.001 ± 4.328  ns/op

jdk18on (java19)

Benchmark                    (SIZE)  Mode  Cnt    Score   Error  Units
KeccakBench.benchmarkKeccak      32  avgt   50  544.367 ± 3.604  ns/op

jdk15t018 (java17)

Benchmark                    (SIZE)  Mode  Cnt    Score   Error  Units
KeccakBench.benchmarkKeccak      32  avgt   50  608.889 ± 7.984  ns/op

jdk18on (java17)

Benchmark                    (SIZE)  Mode  Cnt    Score    Error  Units
KeccakBench.benchmarkKeccak      32  avgt   50  620.537 ± 14.868  ns/op

@fab-10 fab-10 marked this pull request as ready for review October 9, 2023 10:50
Copy link
Contributor

@garyschulte garyschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is JDK 1.8+ right? not jdk 18+

Looks good to me, but it would be wise to get 👀 from @ahamlat

@fab-10
Copy link
Contributor Author

fab-10 commented Oct 10, 2023

This is JDK 1.8+ right? not jdk 18+

Correct, let me amend the title

@fab-10 fab-10 changed the title Force the use of jdk18 version of Bouncy Castle library Force the use of jdk1.8+ version of Bouncy Castle library Oct 10, 2023
@fab-10 fab-10 changed the title Force the use of jdk1.8+ version of Bouncy Castle library Force the use of jdk8+ version of Bouncy Castle library Oct 10, 2023
Copy link
Contributor

@ahamlat ahamlat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce similar numbers regarding JDK 17 and JDK 19. JDK 21 has even better performance for both versions and I didn't notice a difference in performance.

These are some results on Mac M1 Aarch64

Java 21 - jdk15to18 

Benchmark                                         (SIZE)  Mode  Cnt    Score   Error  Units
HashBenchmarking.benchmarkKeccakVersionjdk15to18      32  avgt   50  290.137 ± 2.660  ns/op


Java 21 - jdk18on
Benchmark                                       (SIZE)  Mode  Cnt    Score   Error  Units
HashBenchmarking.benchmarkKeccakVersionjdk18on      32  avgt   50  290.327 ± 2.950  ns/op

@fab-10 fab-10 enabled auto-merge (squash) October 12, 2023 10:14
@fab-10 fab-10 merged commit e5c9f55 into hyperledger:main Oct 12, 2023
@fab-10 fab-10 deleted the bouncy-castle-force-jdk18 branch October 12, 2023 11:59
Gabriel-Trintinalia pushed a commit to Gabriel-Trintinalia/besu that referenced this pull request Oct 20, 2023
…5748)

This avoid that any dependency can include the jdk15 version in the distribution.
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Gabriel-Trintinalia pushed a commit to Gabriel-Trintinalia/besu that referenced this pull request Oct 20, 2023
…5748)

This avoid that any dependency can include the jdk15 version in the distribution.
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Gabriel-Trintinalia added a commit that referenced this pull request Oct 20, 2023
* Expose getSize to transaction interface (#5983)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Add parameters to EVM library fluent API (#5930)

Add the ability to configure more parameters in the fluent API.
Specifically contract address, coinbase, difficulty, mixHash/prevRandao,
baseFee, block number, timestamp, gas limit, previous block hashes, and
versioned hashes. Also create EVM forks parametrically instead of by
a method name.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* Validation ordering (#5986)

* re-ordering error reporting priority
* fixes fork checking on getPayload
* adds acceptance test reproducing an issue where built blocks have proofs > txs
* test coverage and fix for subtle re-org bug prior to proposals
---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* [4844] EngineNewPayload - Add Blob Count validation (#5973)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Plugin Api - Add evaluateTransactionPostProcessing to TransactionSelector interface (#5988)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Only use the builder to create transactions (#5980)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Bump version to 23.10.1-SNAPSHOT (#5990)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* hive tests explicitly attempt zero (#5993)

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* add plugins summary (#5964)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Tests for GraphQL Cancun fields (#5975)

* Tests for GraphQL Cancun fields

Add tests for GraphQL fields added to support cancun.
Also, re-work test case inclusion code and update tests impacted by
adding a new block to the chain.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* unneeded deltas in genesis file

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

---------

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* [Plugin API] - Simplify plugin transaction selector interface to return object instead of list (#5995)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Change Array Copying (#5998)

* Change Array Copying

Change array copying by re-using arrays when safe.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* spotless

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* different bigint API

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* straddle case

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* less stack traces

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* spotless

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

---------

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* [Plugin API] - TransactionSelector - Notify plugins when transaction is selected/rejected (#6005)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Base EIP-6110 on top of Cancun (#5752)

This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification.

Changes include:
-  Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2
-  Rename deposits to depositReceipts in EnginePayloadParameter
-  Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3
-  Revamp the existed 6110 acceptance test

---

Signed-off-by: Navie Chan <naviechan@gmail.com>
Signed-off-by: naviechan <adrninistrator1@protonmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* add method to disable root verification for T8n and not Reference tests (#6013)

* add method to disable root verification for T8n and not Reference tests

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Transaction detachedCopy to optimize txpool memory usage (#5985)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Use existing Bytes48 for KZGCommitment and KZGProof (#5997)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* [Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected (#6010)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Update 23.10.0 changelog (#6017)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Transaction Validation and Selection Plugin API update (#6020)

change Transaction Validation and Selection Plugin to make them more useful

Signed-off-by: Stefan <stefan.pingel@consensys.net>
Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Force the use of jdk18 version of Bouncy Castle library (#5748)

This avoid that any dependency can include the jdk15 version in the distribution.
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* remove code duplication (#6028)

Signed-off-by: Stefan <stefan.pingel@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* docs: fix typo (#6029)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: vuittont60 <vuittontvuittont50@outlook.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Standardize pubkey and public key naming in deposit (#6012)

---------

Signed-off-by: naviechan <adrninistrator1@protonmail.com>
Signed-off-by: Navie Chan <naviechan@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Optimize Eth_feeHistory RPC method (#6011)

* Add a cache to EthFeeHistory and improve rewards algorithm
* cache the rewards by hash instead of block number
* Add final on some fields

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Cache last blocks data (block headers, block bodies, transactions' receipts and total difficulty) (#6009)

* Add a flag --cache-last-blocks to cache last n blocks, The default value is 0

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Sort only once rewardPercentiles instead of doing it for each block header (#6035)

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* link to issue 5772 (#6038)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* fix incorrect argument passing in blockParameter of TraceCallMany class (#6034)

Signed-off-by: seongmin <sungmin7465@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Fix 23.10.0 Breaking Changes changelog entry (#6040)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Priority senders (#5959)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Fcu v2 defer fork validation (#6037)

* more error handling

---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Fix typos (#6036)

Signed-off-by: shuoer86 <129674997+shuoer86@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Add X (Twitter) to README, Fix Roadmap Hyperlink (#6047)

* Add X to README, Fix Roadmap Hyperlink

Signed-off-by: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>

* Update README

Signed-off-by: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>

* Update README

Signed-off-by: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>

---------

Signed-off-by: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Unsigned timestamps and blob gas used (#6046)

* lots of places an unsigned timestamp is a problem
* adds unchecked annotations to OptionalUnsignedLong rpc parameter type

---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* [MINOR] ux improvements (#6049)

* log command line option that is affected

* made plugins summary log part of config overview

* check for null plugin context

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Update changelog release (#6062)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Dencun corner cases (#6060)

* cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* formatting

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* update the EIP-6110 acceptance tests

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Update changelog and gradle properties to next release

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

---------

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Navie Chan <naviechan@gmail.com>
Signed-off-by: naviechan <adrninistrator1@protonmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Stefan <stefan.pingel@consensys.net>
Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: seongmin <sungmin7465@gmail.com>
Signed-off-by: shuoer86 <129674997+shuoer86@users.noreply.github.com>
Signed-off-by: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>
Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: NC <adrninistrator1@protonmail.com>
Co-authored-by: matkt <karim.t2am@gmail.com>
Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Co-authored-by: vuittont60 <vuittontvuittont50@outlook.com>
Co-authored-by: ahamlat <ameziane.hamlat@consensys.net>
Co-authored-by: seongmin <sungmin7465@gmail.com>
Co-authored-by: shuoer86 <129674997+shuoer86@users.noreply.github.com>
Co-authored-by: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>
jflo added a commit to jflo/besu that referenced this pull request Nov 10, 2023
* Expose getSize to transaction interface (hyperledger#5983)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Add parameters to EVM library fluent API (hyperledger#5930)

Add the ability to configure more parameters in the fluent API.
Specifically contract address, coinbase, difficulty, mixHash/prevRandao,
baseFee, block number, timestamp, gas limit, previous block hashes, and
versioned hashes. Also create EVM forks parametrically instead of by
a method name.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* Validation ordering (hyperledger#5986)

* re-ordering error reporting priority
* fixes fork checking on getPayload
* adds acceptance test reproducing an issue where built blocks have proofs > txs
* test coverage and fix for subtle re-org bug prior to proposals
---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* [4844] EngineNewPayload - Add Blob Count validation (hyperledger#5973)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Plugin Api - Add evaluateTransactionPostProcessing to TransactionSelector interface (hyperledger#5988)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Only use the builder to create transactions (hyperledger#5980)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Bump version to 23.10.1-SNAPSHOT (hyperledger#5990)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* hive tests explicitly attempt zero (hyperledger#5993)

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* add plugins summary (hyperledger#5964)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Tests for GraphQL Cancun fields (hyperledger#5975)

* Tests for GraphQL Cancun fields

Add tests for GraphQL fields added to support cancun.
Also, re-work test case inclusion code and update tests impacted by
adding a new block to the chain.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* unneeded deltas in genesis file

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

---------

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* [Plugin API] - Simplify plugin transaction selector interface to return object instead of list (hyperledger#5995)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Change Array Copying (hyperledger#5998)

* Change Array Copying

Change array copying by re-using arrays when safe.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* spotless

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* different bigint API

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* straddle case

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* less stack traces

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

* spotless

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

---------

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* [Plugin API] - TransactionSelector - Notify plugins when transaction is selected/rejected (hyperledger#6005)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Base EIP-6110 on top of Cancun (hyperledger#5752)

This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification.

Changes include:
-  Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2
-  Rename deposits to depositReceipts in EnginePayloadParameter
-  Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3
-  Revamp the existed 6110 acceptance test

---

Signed-off-by: Navie Chan <naviechan@gmail.com>
Signed-off-by: naviechan <adrninistrator1@protonmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* add method to disable root verification for T8n and not Reference tests (hyperledger#6013)

* add method to disable root verification for T8n and not Reference tests

Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Transaction detachedCopy to optimize txpool memory usage (hyperledger#5985)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Use existing Bytes48 for KZGCommitment and KZGProof (hyperledger#5997)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* [Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected (hyperledger#6010)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Update 23.10.0 changelog (hyperledger#6017)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Transaction Validation and Selection Plugin API update (hyperledger#6020)

change Transaction Validation and Selection Plugin to make them more useful

Signed-off-by: Stefan <stefan.pingel@consensys.net>
Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Force the use of jdk18 version of Bouncy Castle library (hyperledger#5748)

This avoid that any dependency can include the jdk15 version in the distribution.
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* remove code duplication (hyperledger#6028)

Signed-off-by: Stefan <stefan.pingel@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* docs: fix typo (hyperledger#6029)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: vuittont60 <vuittontvuittont50@outlook.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Standardize pubkey and public key naming in deposit (hyperledger#6012)

---------

Signed-off-by: naviechan <adrninistrator1@protonmail.com>
Signed-off-by: Navie Chan <naviechan@gmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Optimize Eth_feeHistory RPC method (hyperledger#6011)

* Add a cache to EthFeeHistory and improve rewards algorithm
* cache the rewards by hash instead of block number
* Add final on some fields

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Cache last blocks data (block headers, block bodies, transactions' receipts and total difficulty) (hyperledger#6009)

* Add a flag --cache-last-blocks to cache last n blocks, The default value is 0

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Sort only once rewardPercentiles instead of doing it for each block header (hyperledger#6035)

Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* link to issue 5772 (hyperledger#6038)

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* fix incorrect argument passing in blockParameter of TraceCallMany class (hyperledger#6034)

Signed-off-by: seongmin <sungmin7465@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Fix 23.10.0 Breaking Changes changelog entry (hyperledger#6040)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Priority senders (hyperledger#5959)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Fcu v2 defer fork validation (hyperledger#6037)

* more error handling

---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Fix typos (hyperledger#6036)

Signed-off-by: shuoer86 <129674997+shuoer86@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Add X (Twitter) to README, Fix Roadmap Hyperlink (hyperledger#6047)

* Add X to README, Fix Roadmap Hyperlink

Signed-off-by: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>

* Update README

Signed-off-by: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>

* Update README

Signed-off-by: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>

---------

Signed-off-by: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Unsigned timestamps and blob gas used (hyperledger#6046)

* lots of places an unsigned timestamp is a problem
* adds unchecked annotations to OptionalUnsignedLong rpc parameter type

---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* [MINOR] ux improvements (hyperledger#6049)

* log command line option that is affected

* made plugins summary log part of config overview

* check for null plugin context

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Update changelog release (hyperledger#6062)

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Dencun corner cases (hyperledger#6060)

* cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* formatting

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

* update the EIP-6110 acceptance tests

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

* Update changelog and gradle properties to next release

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>

---------

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Navie Chan <naviechan@gmail.com>
Signed-off-by: naviechan <adrninistrator1@protonmail.com>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Stefan <stefan.pingel@consensys.net>
Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: seongmin <sungmin7465@gmail.com>
Signed-off-by: shuoer86 <129674997+shuoer86@users.noreply.github.com>
Signed-off-by: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>
Co-authored-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: NC <adrninistrator1@protonmail.com>
Co-authored-by: matkt <karim.t2am@gmail.com>
Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Co-authored-by: vuittont60 <vuittontvuittont50@outlook.com>
Co-authored-by: ahamlat <ameziane.hamlat@consensys.net>
Co-authored-by: seongmin <sungmin7465@gmail.com>
Co-authored-by: shuoer86 <129674997+shuoer86@users.noreply.github.com>
Co-authored-by: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
…5748)

This avoid that any dependency can include the jdk15 version in the distribution.
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants