Skip to content

Retry when rocksDB returns Busy status code #5287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gfukushima wants to merge 1 commit into from
Closed

Retry when rocksDB returns Busy status code #5287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion ...ledger/besu/plugin/services/storage/rocksdb/segmented/RocksDBColumnarKeyValueStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ public class RocksDBColumnarKeyValueStorage
private static final Logger LOG = LoggerFactory.getLogger(RocksDBColumnarKeyValueStorage.class);
private static final String DEFAULT_COLUMN = "default";
private static final String NO_SPACE_LEFT_ON_DEVICE = "No space left on device";
private static final int MAX_BUSY_RETRIES = 5;
private static final int BUSY_RETRY_MILLISECONDS_INTERVAL = 100;
private static final int ROCKSDB_FORMAT_VERSION = 5;
private static final long ROCKSDB_BLOCK_SIZE = 32768;
private static final long ROCKSDB_BLOCKCACHE_SIZE_HIGH_SPEC = 1_073_741_824L;
Expand Down Expand Up @@ -405,12 +407,37 @@ public synchronized void commit() throws StorageException {
LOG.error(e.getMessage());
System.exit(0);
}
throw new StorageException(e);
if (e.getStatus().getCode() == Status.Code.Busy) {
LOG.error(e.getMessage());
commitRetry(MAX_BUSY_RETRIES);
} else {
throw new StorageException(e);
}
} finally {
close();
}
}

private void commitRetry(final int retries) {
if (retries == 0) {
LOG.error("RocksDB Busy - Already retried {} times", MAX_BUSY_RETRIES);
} else {
try {
LOG.debug("Retries left: {}", retries - 1);
innerTx.rollback();
metrics.getRollbackCount().inc();
Thread.sleep(BUSY_RETRY_MILLISECONDS_INTERVAL);
innerTx.commit();
} catch (final RocksDBException e) {
if (e.getStatus().getCode() == Status.Code.Busy) {
commitRetry(retries - 1);
}
} catch (final InterruptedException e) {
throw new RuntimeException(e);
}
}
}

@Override
public void rollback() {
try {
Expand Down
38 changes: 32 additions & 6 deletions .../org/hyperledger/besu/plugin/services/storage/rocksdb/unsegmented/RocksDBTransaction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,18 @@
import org.hyperledger.besu.plugin.services.storage.rocksdb.RocksDBMetrics;

import org.rocksdb.RocksDBException;
import org.rocksdb.Status;
import org.rocksdb.Transaction;
import org.rocksdb.WriteOptions;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/** The RocksDb transaction. */
public class RocksDBTransaction implements KeyValueStorageTransaction {
private static final Logger logger = LoggerFactory.getLogger(RocksDBTransaction.class);
private static final Logger LOG = LoggerFactory.getLogger(RocksDBTransaction.class);
private static final String NO_SPACE_LEFT_ON_DEVICE = "No space left on device";

private static final int MAX_BUSY_RETRIES = 5;
private static final int BUSY_RETRY_MILLISECONDS_INTERVAL = 100;
private final RocksDBMetrics metrics;
private final Transaction innerTx;
private final WriteOptions options;
Expand All @@ -54,7 +56,7 @@ public void put(final byte[] key, final byte[] value) {
innerTx.put(key, value);
} catch (final RocksDBException e) {
if (e.getMessage().contains(NO_SPACE_LEFT_ON_DEVICE)) {
logger.error(e.getMessage());
LOG.error(e.getMessage());
System.exit(0);
}
throw new StorageException(e);
Expand All @@ -67,7 +69,7 @@ public void remove(final byte[] key) {
innerTx.delete(key);
} catch (final RocksDBException e) {
if (e.getMessage().contains(NO_SPACE_LEFT_ON_DEVICE)) {
logger.error(e.getMessage());
LOG.error(e.getMessage());
System.exit(0);
}
throw new StorageException(e);
Expand All @@ -80,23 +82,47 @@ public void commit() throws StorageException {
innerTx.commit();
} catch (final RocksDBException e) {
if (e.getMessage().contains(NO_SPACE_LEFT_ON_DEVICE)) {
logger.error(e.getMessage());
LOG.error(e.getMessage());
System.exit(0);
}
if (e.getStatus().getCode() == Status.Code.Busy) {
LOG.error(e.getMessage());
commitRetry(MAX_BUSY_RETRIES);
}
throw new StorageException(e);
} finally {
close();
}
}

private void commitRetry(final int retries) {
if (retries == 0) {
LOG.error("RocksDB Busy - Already retried {} times", MAX_BUSY_RETRIES);
} else {
try {
LOG.debug("Retries left: {}", retries - 1);
innerTx.rollback();
metrics.getRollbackCount().inc();
Thread.sleep(BUSY_RETRY_MILLISECONDS_INTERVAL);
innerTx.commit();
} catch (final RocksDBException e) {
if (e.getStatus().getCode() == Status.Code.Busy) {
commitRetry(retries - 1);
}
} catch (final InterruptedException e) {
throw new RuntimeException(e);
}
}
}

@Override
public void rollback() {
try {
innerTx.rollback();
metrics.getRollbackCount().inc();
} catch (final RocksDBException e) {
if (e.getMessage().contains(NO_SPACE_LEFT_ON_DEVICE)) {
logger.error(e.getMessage());
LOG.error(e.getMessage());
System.exit(0);
}
throw new StorageException(e);
Expand Down