Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DebugGetRawBlock and DebugGetRawHeader missing methods #5011

Merged
merged 4 commits into from
Jan 28, 2023
Merged

DebugGetRawBlock and DebugGetRawHeader missing methods #5011

merged 4 commits into from
Jan 28, 2023

Conversation

Gabriel-Trintinalia
Copy link
Contributor

PR description

Adds two missing methods as per api-documentation:

  • DebugGetRawBlock - Returns an RLP-encoded block.
  • DebugGetRawHeader - Returns an RLP-encoded header.

Fixes hive tests:

  • debug_getRawBlock/get-block-n (besu)
  • debug_getRawBlock/get-genesis (besu)
  • debug_getRawBlock/get-invalid-number (besu)
  • debug_getRawHeader/get-block-n (besu)
  • debug_getRawHeader/get-genesis (besu)
  • debug_getRawHeader/get-invalid-number (besu)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@Gabriel-Trintinalia
Add debug get raw header method
072edd6 
Signed-off-by: Gabriel Trintinalia <[email protected]>
@Gabriel-Trintinalia
Add debug get raw block method
1996045 
Signed-off-by: Gabriel Trintinalia <[email protected]>
@Gabriel-Trintinalia Gabriel-Trintinalia added doc-change-required Indicates an issue or PR that requires doc to be updated TeamRevenant GH issues worked on by Revenant Team labels Jan 26, 2023
@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as ready for review January 26, 2023 20:29
macfarla
macfarla approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. maybe a changelog entry?

@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 85a7dff into hyperledger:main Jan 28, 2023
@alexandratran alexandratran mentioned this pull request Feb 1, 2023
Closed
1 task
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Feb 1, 2023
fab-10 pushed a commit to fab-10/besu that referenced this pull request Feb 1, 2023
@Gabriel-Trintinalia @fab-10
DebugGetRawBlock and DebugGetRawHeader missing methods (hyperledger#5011
f317152 
)

Signed-off-by: Gabriel-Trintinalia <[email protected]>
fab-10 pushed a commit to fab-10/besu that referenced this pull request Feb 1, 2023
@Gabriel-Trintinalia @fab-10
DebugGetRawBlock and DebugGetRawHeader missing methods (hyperledger#5011
8f66cb9 
)

Signed-off-by: Gabriel-Trintinalia <[email protected]>
dhallatmaine pushed a commit to dhallatmaine/besu that referenced this pull request Feb 1, 2023
@Gabriel-Trintinalia @dhallatmaine
DebugGetRawBlock and DebugGetRawHeader missing methods (hyperledger#5011
c700371 
)

Signed-off-by: Gabriel Trintinalia <[email protected]>
ensi321 pushed a commit to ensi321/besu that referenced this pull request Feb 19, 2023
@Gabriel-Trintinalia @ensi321
DebugGetRawBlock and DebugGetRawHeader missing methods (hyperledger#5011
5849464 
)

Signed-off-by: Gabriel Trintinalia <[email protected]>
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the debug-get-raw-block branch March 9, 2023 01:28
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
@Gabriel-Trintinalia @elenduuche
DebugGetRawBlock and DebugGetRawHeader missing methods (hyperledger#5011
ae5243e 
)

Signed-off-by: Gabriel Trintinalia <[email protected]>
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
@Gabriel-Trintinalia @eum602
DebugGetRawBlock and DebugGetRawHeader missing methods (hyperledger#5011
431d541 
)

Signed-off-by: Gabriel Trintinalia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

@jflo jflo jflo approved these changes

Assignees
No one assigned
Labels
mainnet TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gabriel-Trintinalia @jflo @macfarla @alexandratran