Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send only hash announcement for blob transaction type #4940

Merged
merged 8 commits into from
Jan 20, 2023

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Jan 16, 2023

Signed-off-by: Fabio Di Fabio [email protected]

PR description

When broadcasting transactions to peers, handle 4844 blob transactions in the following ways:

  • For pre-eth/65 peers 4844 blob transactions are ignore are not sent
  • For eth/65+ peers selected for full transaction body broadcast, a mixed approach is taken, and 2 messages are sent:
    • non-blob transactions are sent in full as before
    • for 4844 blob transactions only the hash is announced
  • For eth/65+ peers selected for hash only announcements, same strategy as before, for all transactions (including 4844 blob ones) only the hashes are announced

Fixed Issue(s)

fixes #4821

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@fab-10 fab-10 marked this pull request as draft January 16, 2023 13:10
@fab-10 fab-10 mentioned this pull request Jan 16, 2023
22 tasks
@fab-10 fab-10 force-pushed the blob-tx-broadcast branch from d12f450 to ed86cdc Compare January 16, 2023 13:32
@fab-10 fab-10 force-pushed the blob-tx-broadcast branch from 483a529 to a46784a Compare January 17, 2023 19:50
@fab-10 fab-10 marked this pull request as ready for review January 17, 2023 19:51
# Conflicts:
#	ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionBroadcaster.java
#	ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/transactions/TransactionBroadcasterTest.java
@fab-10 fab-10 enabled auto-merge (squash) January 20, 2023 09:33
@fab-10 fab-10 merged commit 3850d49 into hyperledger:main Jan 20, 2023
@fab-10 fab-10 deleted the blob-tx-broadcast branch January 20, 2023 10:12
elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4844 Transaction Broadcast
2 participants