PoS checkpoint sync by gfukushima · Pull Request #4844 · hyperledger/besu

gfukushima · 2022-12-20T14:23:34Z

PR description

Enables PoS checkpoint sync under an experimental flag

Fixed Issue(s)

Fixes #4573

Documentation

I thought about documentation and added the doc-change-required label to this PR if
updates are required.

Changelog

I thought about the changelog and included a changelog update if required.

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

…troller Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

besu/src/main/java/org/hyperledger/besu/controller/BesuController.java

besu/src/test/java/org/hyperledger/besu/PrivacyTest.java

besu/src/test/java/org/hyperledger/besu/cli/BesuCommandTest.java

consensus/merge/src/main/java/org/hyperledger/besu/consensus/merge/PostMergeContext.java

besu/src/main/java/org/hyperledger/besu/controller/BesuController.java

besu/src/main/java/org/hyperledger/besu/controller/MergeBesuControllerBuilder.java

besu/src/test/java/org/hyperledger/besu/chainimport/RlpBlockImporterTest.java

consensus/merge/src/main/java/org/hyperledger/besu/consensus/merge/PostMergeContext.java

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

siladu

LGTM 🎉

matkt · 2022-12-21T15:03:26Z

besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java

            .isPresent());
  }

+  private void validatePostMergeCheckpointBlockRequirements() {


why all of this check are not in the valid method of CheckpointConfigOptions ?

matkt · 2022-12-21T15:05:53Z

besu/src/main/java/org/hyperledger/besu/controller/BesuController.java

    }
+
+    private boolean isCheckpointPoSBlock(final GenesisConfigOptions configOptions) {
+      final UInt256 terminalTotalDifficulty = configOptions.getTerminalTotalDifficulty().get();


I think we cannot have empty here ?

matkt · 2022-12-21T15:08:47Z

besu/src/main/java/org/hyperledger/besu/controller/BesuController.java

+    private boolean isCheckpointPoSBlock(final GenesisConfigOptions configOptions) {
+      final UInt256 terminalTotalDifficulty = configOptions.getTerminalTotalDifficulty().get();
+
+      return configOptions.getCheckpointOptions().isValid()


we are not already checking if it is valid here ? https://github.com/hyperledger/besu/pull/4844/files#diff-2080ac0bf38c1e492921f4191b738b729195e0b1ad82657abc9103f19ac87cd8R3368

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

gfukushima added 30 commits December 20, 2022 17:16

Add validations of new experimental flag

d31d63f

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add check to call MergeController without the using the TransitionCon…

5e73c6b

…troller Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add experimental flag

1bf75c0

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add parser

70bd193

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add isNearHeadCheckpointSync method to interface

acca61e

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add isNearHeadCheckpointSync implementations

3eb7015

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add attribute for the new flag

9b38c51

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Pass value to MergeContext

1ce3021

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add unit tests

d6480d2

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add resource for unit test

e8ecdd8

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add check for optional

98d107a

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Spotless apply

038105e

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Use Default

c69f15c

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add new field to be ignored

fa2c745

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Fix params order

bafebeb

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Change validation order

8e57f86

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Refactor validation

06350eb

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Spotless

8a650c3

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add extra unit test

3fff7f3

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Rename variable

4861991

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Remove parser

03a9ec6

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Remove parser

3190822

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Change validation to use total difficulty

b5e2994

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Change validation to use total difficulty

f69d296

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add validation for checkpoint config

5847166

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Refactor code to reflect current state of the feature.

ce85fac

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add unit test

defaae8

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

spotless

7c37113

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Fix logic for isSyncing method covering possible NPE

a4d44e4

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add cover for TTD = TD of the checkpoint block (merge at genesis)

ba516c4

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

gfukushima added 9 commits December 20, 2022 17:33

Pass syncMode to BesuController.Builder to allow checkpointsync PoS

943aa80

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Fix difficulty of invalid genesis

ed5f29f

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Add static method

4658d7e

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Pass syncMode to BesuController builder

81245bd

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

spotless

9c194fd

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Resolve conflicts

6f8b6b7

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

spotless

858fdfc

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

spotless

56cfd7b

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

spotless

fdc0a47

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

siladu reviewed Dec 20, 2022

View reviewed changes

jframe reviewed Dec 21, 2022

View reviewed changes

gfukushima added 4 commits December 21, 2022 12:08

Move invalid configuration check to BesuCommand

a25e93b

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Set default sync mode for PrivacyTest

7178173

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Rename method

d768c87

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Rename method

5926fe3

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

jframe approved these changes Dec 21, 2022

View reviewed changes

siladu approved these changes Dec 21, 2022

View reviewed changes

Merge branch 'main' into PoS-checkpoint-sync

5986580

gfukushima enabled auto-merge (squash) December 21, 2022 04:00

gfukushima merged commit 7d5988d into hyperledger:main Dec 21, 2022

This was referenced Dec 21, 2022

Post Merge checkpoint sync #4735

Closed

Possible npe fix #4811

Closed

matkt reviewed Dec 21, 2022

View reviewed changes

jflo pushed a commit to jflo/besu that referenced this pull request Dec 22, 2022

PoS checkpoint sync (hyperledger#4844)

31e27c5

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>

macfarla pushed a commit to macfarla/besu that referenced this pull request Jan 10, 2023

PoS checkpoint sync (hyperledger#4844)

1e467b8

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

gfukushima deleted the PoS-checkpoint-sync branch January 13, 2023 07:07

gfukushima added the mainnet label Jan 24, 2023

garyschulte mentioned this pull request Feb 24, 2023

propose Simon Dudley protocolguild/documentation#48

Merged

garyschulte mentioned this pull request Apr 4, 2023

propose Gabriel Fukushima protocolguild/documentation#56

Merged

eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023

PoS checkpoint sync (hyperledger#4844)

e19c0a8

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

PoS checkpoint sync#4844

PoS checkpoint sync#4844
gfukushima merged 50 commits intohyperledger:mainfrom
gfukushima:PoS-checkpoint-sync

gfukushima commented Dec 20, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

siladu left a comment

Uh oh!

matkt Dec 21, 2022

Uh oh!

matkt Dec 21, 2022

Uh oh!

matkt Dec 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

gfukushima commented Dec 20, 2022

PR description

Fixed Issue(s)

Documentation

Changelog

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

siladu left a comment

Choose a reason for hiding this comment

Uh oh!

matkt Dec 21, 2022

Choose a reason for hiding this comment

Uh oh!

matkt Dec 21, 2022

Choose a reason for hiding this comment

Uh oh!

matkt Dec 21, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants