Skip to content

Comments

Add accessList field to Transaction Call Object#4802

Merged
Gabriel-Trintinalia merged 10 commits intohyperledger:mainfrom
Gabriel-Trintinalia:4801-transaction-call-access-list
Dec 13, 2022
Merged

Add accessList field to Transaction Call Object#4802
Gabriel-Trintinalia merged 10 commits intohyperledger:mainfrom
Gabriel-Trintinalia:4801-transaction-call-access-list

Conversation

@Gabriel-Trintinalia
Copy link
Contributor

Signed-off-by: Gabriel Trintinalia gabriel.trintinalia@gmail.com

PR description

Besu does not seem to accept AccessList as a parameter:
https://geth.ethereum.org/docs/rpc/objects#transaction-call-object
https://besu.hyperledger.org/en/stable/public-networks/reference/api/objects/#transaction-call-object

Fixed Issue(s)

#4801

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
@Gabriel-Trintinalia Gabriel-Trintinalia added the doc-change-required Indicates an issue or PR that requires doc to be updated label Dec 11, 2022
@Gabriel-Trintinalia Gabriel-Trintinalia marked this pull request as ready for review December 12, 2022 00:52
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wondering if we need extra tests

Gabriel-Trintinalia and others added 4 commits December 13, 2022 13:54
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
Signed-off-by: Gabriel Trintinalia <gabriel.trintinalia@gmail.com>
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 3ae9e25 into hyperledger:main Dec 13, 2022
jframe pushed a commit to jframe/besu that referenced this pull request Dec 16, 2022
Signed-off-by: Gabriel Trintinalia gabriel.trintinalia@gmail.com
jframe pushed a commit that referenced this pull request Dec 16, 2022
Signed-off-by: Gabriel Trintinalia gabriel.trintinalia@gmail.com
matkt pushed a commit to matkt/besu that referenced this pull request Dec 17, 2022
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
ahamlat pushed a commit to ahamlat/besu that referenced this pull request Dec 18, 2022
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Dec 19, 2022
jflo pushed a commit to jflo/besu that referenced this pull request Dec 22, 2022
Signed-off-by: Justin Florentine <justin+github@florentine.us>
macfarla pushed a commit to jflo/besu that referenced this pull request Jan 10, 2023
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the 4801-transaction-call-access-list branch January 16, 2023 16:18
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
Signed-off-by: Gabriel Trintinalia gabriel.trintinalia@gmail.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants