Better handler for --fast-sync-min-peers flag#4481
Merged
macfarla merged 7 commits intohyperledger:mainfrom Oct 7, 2022
Merged
Better handler for --fast-sync-min-peers flag#4481macfarla merged 7 commits intohyperledger:mainfrom
macfarla merged 7 commits intohyperledger:mainfrom
Conversation
… any other sync-mode rather than FULL sync Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…de rather than FULL sync Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…-peers Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
fab-10
approved these changes
Oct 6, 2022
Contributor
fab-10
left a comment
fab-10
left a comment
There was a problem hiding this comment.
LGTM, just add a CHANGELOG entry
Contributor
|
I don't think it needs a changelog entry - it's more a change to handling incompatible options rather than changing functionality |
macfarla
added
dev experience
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Change validation for fast-sync-min-peers to allow it to be used with any other sync-mode rather than FULL sync * Test to ensure fast-sync-min-peers can be used with any other sync-mode rather than FULL sync Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Changes the misleading warn of --fast-sync-min-peers to a more accurate handler which throws a ParameteresException only if this flag is used combined with sync-mode=FULL
Fixed Issue(s)
fixes #4315
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog