Add fields to eth_getTransaction series of RPCs #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fields for `chainId`, `publicKey`, and `raw` to RPCs where detailed transaction data is returned (`eth_getTransactionByBlockHash`, `eth_getTransactionByBlockNumber`, `eth_getTransactionByHash`, and `eth_getBlock` with certain parameters). Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
RatanRSur
approved these changes
Jan 26, 2021
Comment on lines
+408
to
+412
| public Optional<String> getPublicKey() { | ||
| return SECP256K1.PublicKey.recoverFromSignature(getOrComputeSenderRecoveryHash(), signature) | ||
| .map(PublicKey::toString); | ||
| } | ||
|
|
There was a problem hiding this comment.
(optional) Maybe make this return PublicKey and have the caller toString it?
macfarla
reviewed
Jan 27, 2021
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| * `--skip-pow-validation-enabled` is now an error with `block import --format JSON`. This is because the JSON format doesn't include the nonce so the proof of work must be calculated. [\#1815](https://github.com/hyperledger/besu/pull/1815) | |||
| * Added a new CLI option `--Xlauncher` to start a mainnet launcher. It will help to configure Besu easily. | |||
| * Return the revert reason from `eth_call` JSON-RPC api calls when the contract causes a revert. [\#1829](https://github.com/hyperledger/besu/pull/1829) | |||
| * Added `chainId`, `publicKey`, and `raw` to JSON-RPC api calls returning detailed transaction results. [\#1835]((https://github.com/hyperledger/besu/pull/1835) | |||
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| * `--skip-pow-validation-enabled` is now an error with `block import --format JSON`. This is because the JSON format doesn't include the nonce so the proof of work must be calculated. [\#1815](https://github.com/hyperledger/besu/pull/1815) | |||
| * Added a new CLI option `--Xlauncher` to start a mainnet launcher. It will help to configure Besu easily. | |||
| * Return the revert reason from `eth_call` JSON-RPC api calls when the contract causes a revert. [\#1829](https://github.com/hyperledger/besu/pull/1829) | |||
| * Added `chainId`, `publicKey`, and `raw` to JSON-RPC api calls returning detailed transaction results. [\#1835]((https://github.com/hyperledger/besu/pull/1835) | |||
|
|
|||
| ### Bug Fixes | |||
| * Ethereum classic heights will no longer be reported in mainnet metrics. Issue [\#1751]((https://github.com/hyperledger/besu/pull/1751) Fix [\#1820](https://github.com/hyperledger/besu/pull/1820) | |||
shemnon
added
the
doc-change-required
|
Doc change is to update the JSON-RPC samples to show the three included fields in calls to |
Signed-off-by: Danno Ferrin <[email protected]>
bgravenorst
removed
the
doc-change-required
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Add fields for `chainId`, `publicKey`, and `raw` to RPCs where detailed transaction data is returned (`eth_getTransactionByBlockHash`, `eth_getTransactionByBlockNumber`, `eth_getTransactionByHash`, and `eth_getBlock` with certain parameters). Signed-off-by: Danno Ferrin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fields for
chainId,publicKey, andrawto RPCs where detailedtransaction data is returned (
eth_getTransactionByBlockHash,eth_getTransactionByBlockNumber,eth_getTransactionByHash, andeth_getBlockwith certain parameters).Addresses #1802
Signed-off-by: Danno Ferrin [email protected]
Changelog