Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support computing proof with n arguments #89

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Sep 22, 2022

Signed-off-by: Antoine Toulme [email protected]

Instead of using 4 arguments, allow to use n arguments for the commit method.

@atoulme atoulme enabled auto-merge (squash) September 23, 2022 07:37
@atoulme atoulme merged commit 750e767 into hyperledger:main Sep 23, 2022
@atoulme atoulme deleted the ipa_n_args branch October 3, 2022 15:31
public void testCallLibraryWithManyElements() {
Bytes input = Bytes.fromHexString("0x0cfe3041fb6512c87922e2146c8308b372f3bf967f889e69ad116ce7c7ec840cfe3041fb6512c87922e2146c8308b372f3bf967f889e69ad116ce7c7ec840cfe3041fb6512c87922e2146c8308b372f3bf967f889e69ad116ce7c7ec840cfe3041fb6512c87922e2146c8308b372f3bf967f889e69ad116ce7c7ec84");
List<byte[]> params = new ArrayList<>();
for (int i = 0 ; i < 128; i++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @atoulme i've been looking into the ipa-multipoint wrapper, and have one question. Where are these numbers pulled from? I mean 0x0cfe3041fb6512c87922e2146c8308b372f3bf967f889e69ad116ce7c7ec840cfe3041fb6512c87922e2146c8308b372f3bf967f889e69ad116ce7c7ec840cfe3041fb6512c87922e2146c8308b372f3bf967f889e69ad116ce7c7ec840cfe3041fb6512c87922e2146c8308b372f3bf967f889e69ad116ce7c7ec84 for example

Also, should we make the for loop go up to 256 values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s a test. I picked up this number, ran it with go impl, then used it here to create a test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atoulme thanks, makes sense. Btw did you mean you ran it with rust impl?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No with the go impl. Though rust should match

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants