-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ipa-multipoint library integration #56
Conversation
721eb1d
to
85dd3ad
Compare
Context for this PR: verkle trees replace hashes with polynomial commitments. These polynomials are computed over an elliptic curve, called bandersnatch. This PR provides the function that takes the coefficients of the polynomial and evaluates it: It's, therefore, the basic building block of verkle trees. |
14b06a7
to
4095c08
Compare
Signed-off-by: Antoine Toulme <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple nitpicks
Signed-off-by: Antoine Toulme <[email protected]>
Signed-off-by: Antoine Toulme <[email protected]>
Signed-off-by: Antoine Toulme <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't meaningfully comment on the rust impl. Feedback about multi-arch darwin jars should be easy to implement
ipa-multipoint/src/main/java/org/hyperledger/besu/nativelib/ipamultipoint/LibIpaMultipoint.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Antoine Toulme <[email protected]>
Signed-off-by: Antoine Toulme <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ipa-multipoint/src/main/java/org/hyperledger/besu/nativelib/ipamultipoint/LibIpaMultipoint.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Antoine Toulme <[email protected]>
No description provided.