ICS-20: Add JSON encoding support #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
|
what is possible timeline this to be merged into main? or at least squash (so easy maintain forks/merges/rebases) |
| assertFalse(ICS20LibTestHelper.isEscapedJSONString('abc"')); | ||
| assertFalse(ICS20LibTestHelper.isEscapedJSONString('"abc')); | ||
| assertFalse(ICS20LibTestHelper.isEscapedJSONString('a"bc')); | ||
|
|
There was a problem hiding this comment.
123ibc/SDHWEQWEWQEQW is also True
There was a problem hiding this comment.
yeah, I will add more test cases
| string calldata sourcePort, | ||
| string calldata sourceChannel, | ||
| uint64 timeoutHeight | ||
| ) external { | ||
| if (!denom.toSlice().startsWith(_makeDenomPrefix(sourcePort, sourceChannel))) { | ||
| require(ICS20Lib.isEscapedJSONString(denom) && ICS20Lib.isEscapedJSONString(receiver), "unescaped string"); |
There was a problem hiding this comment.
i doubt you should validate. it will just burn gas. people already send right strings, or get pack fail ACK.
There was a problem hiding this comment.
First, denom can be removed by making this a contract to IICS20Bank implementers. I will revert a change in 201e8f5
A format of receiver is not defined in ics-20, so I think this validation is basically necessary as it depends on the ics-20 impl on the counterparty chain.
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
…not constant gas cost Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #81