Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: weaver/testutils version in all go modules #466

Merged
merged 2 commits into from
May 24, 2024
Merged

bump: weaver/testutils version in all go modules #466

merged 2 commits into from
May 24, 2024

Conversation

sandeepnRES
Copy link
Member

Also following changes:

  • Update go-gen-checksum script to handle error cases.
  • Update go-mod-tidy to be useful to fix broken go.mods.

VRamakrishna
VRamakrishna reviewed May 24, 2024
View reviewed changes
go-gen-checksum.sh Outdated Show resolved Hide resolved
VRamakrishna
VRamakrishna reviewed May 24, 2024
View reviewed changes
go-gen-checksum.sh Outdated Show resolved Hide resolved
VRamakrishna
VRamakrishna approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@VRamakrishna VRamakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some minor comments. Please address and merge.

@sandeepnRES sandeepnRES merged commit d4e3827 into hyperledger-labs:main May 24, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VRamakrishna VRamakrishna VRamakrishna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandeepnRES @VRamakrishna