Refactor putRecursive to avoid getRecursive and updating unchanged assets #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mikaellafs <[email protected]>
Signed-off-by: mikaellafs <[email protected]>
Signed-off-by: mikaellafs <[email protected]>
Signed-off-by: André Macedo <[email protected]>
Signed-off-by: André Macedo <[email protected]>
andremacedopv
requested changes
Oct 27, 2023
There was a problem hiding this comment.
@mikaellafs Everything worked fine in my tests here, but is there a reason to maintain the root parameter in the putRecursive method? I think there is no reason for it there after the refactor
Humm you're right, better we remove it |
Signed-off-by: mikaellafs <[email protected]>
mikaellafs
force-pushed
the
refactor/update-recursive
branch
from
4e9bc60 to
b7ef139
Compare
andremacedopv
approved these changes
Oct 27, 2023
samuelvenzi
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.