refactor(iroha_torii): spawn a single server task with only one TcpListener
#5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x009922
added
Refactor
0x009922
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
DCNick3 and
dima74
as code owners
0x009922
changed the title
TcpListener
8 tasks
Erigara
approved these changes
Oct 4, 2024
s8sato
reviewed
Oct 7, 2024
…istener` Signed-off-by: 0x009922 <[email protected]>
0x009922
force-pushed
the
refactor/torii-single-tcp
branch
from
ceed6a8 to
2861ab3
Compare
Erigara
approved these changes
Oct 8, 2024
mversic
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Split from #5087
Chore refactor: there was extra code complexity in Torii due to
iroha_primities::SocketAddrnot implementingtokio::ToSocketAddrs.Solution
Workarounded with a match construction.
Migration Guide (optional)
None
Review notes (optional)
None
Checklist
CONTRIBUTING.md.