fix(common): servers#startOnPreferredPort no graceful fallback #683 #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takeutak
previously approved these changes
Mar 23, 2021
kikoncuo
previously approved these changes
Mar 23, 2021
petermetz
force-pushed
the
fix-683
branch
2 times, most recently
from
38fafbd to
1ebfd32
Compare
takeutak
approved these changes
Mar 25, 2021
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
…edger-cacti#683 The code of the method was not waiting for a promise to resolve which was masking the underlying exception that the code was supposed to catch and examine in order to determine if it should perform a fallback of binding to port zero or not. Fixed it by making sure the initial try of the preferred port allocation is awaited for so that the exception is thrown where it is expected by the algorithm. Fixes hyperledger-cacti#683 Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
Depends on #656
Commit to be reviewed
fix(common): servers#startOnPreferredPort no graceful fallback #683
The code of the method was not waiting for a promise to resolve
which was masking the underlying exception that the code
was supposed to catch and examine in order to determine if
it should perform a fallback of binding to port zero or not.
Fixed it by making sure the initial try of the preferred port
allocation is awaited for so that the exception is thrown
where it is expected by the algorithm.
Fixes #683
Signed-off-by: Peter Somogyvari [email protected]