feat(ccmodel-hepheastus): add Hepheastus plugin #3641
Conversation
Implementation of the paper Hepheastus https://ieeexplore.ieee.org/document/10363680 Authored-by: Bruno Mateus <[email protected]> Co-authored-by: Rafael Belchior <[email protected]> Signed-off-by: Rafael Belchior <[email protected]>
RafaelAPB
requested review from
petermetz,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
|
This PR/issue depends on:
|
There was a problem hiding this comment.
@RafaelAPB I left some suggestions in the code, but it's fine by me if you'd prefer to address those later or never. I want to make sure I'm not slowing down the development.
...ages/cactus-plugin-ccmodel-hephaestus/src/main/typescript/pm4py-adapter/check_conformance.py
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-ccmodel-hephaestus/src/main/typescript/plugin-ccmodel-hephaestus.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-ccmodel-hephaestus/src/main/typescript/plugin-ccmodel-hephaestus.ts
Outdated
Show resolved
Hide resolved
| }; | ||
| } | ||
|
|
||
| private pollTxReceiptsBesu( |
There was a problem hiding this comment.
@RafaelAPB Does this do any actual polling? It looks like it just massages the data. If I'm understanding it correctly then I'd recommend renaming it to something expressing that instead of polling for tx receipts.
There was a problem hiding this comment.
okay, I removed pollTxReceiptsBesu, and now the createReceiptFromRunTransactionV1ExchangeBesu is directly called when receiving data through the Observable. Same with the other 2 "poll" methods.
packages/cactus-plugin-ccmodel-hephaestus/src/main/typescript/plugin-ccmodel-hephaestus.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-ccmodel-hephaestus/src/main/typescript/plugin-ccmodel-hephaestus.ts
Outdated
Show resolved
Hide resolved
| const logName = name | ||
| ? `${name}.json` | ||
| : `hephaestus_log_${startTime.getTime()}.json`; | ||
| const jsonFolder = path.join(__dirname, "../", "../", "test", "json"); |
There was a problem hiding this comment.
@RafaelAPB Depending on this will break the code in production when it is under a different sub-directory path (./dist/lib/.../) I recommend making it configurable through constructor parameters so that this issue can be avoided
packages/cactus-plugin-ccmodel-hephaestus/src/main/typescript/plugin-ccmodel-hephaestus.ts
Outdated
Show resolved
Hide resolved
|
@petermetz @RafaelAPB I also added a quick message about the python dependency in the prerequisites of |
|
@brunoffmateus Dependencies should always be documented as explicitly as possible (better yet via automation that fails with a helpful error message). So please do not remove it. It's great that you did what you did. :-) |
|
@brunoffmateus LGTM but please fix the linter |
Authored-by: Bruno Mateus <[email protected]> Signed-off-by: Rafael Belchior <[email protected]>
|
@petermetz i believe your concerns are addressed. Can we use the squash and merge functionality (there are 2 PRs), or should they be squashed? |
RafaelAPB
force-pushed
the
satp-dev-fixup-hepheastus
branch
from
9b0aa48
to
bb94b91
Compare
Implementation of the paper Hepheastus https://ieeexplore.ieee.org/document/10363680
Depends on #3638 and #3639;: #3642, #3643 #3644
Authored-by: Bruno Mateus [email protected]
Co-authored-by: Rafael Belchior [email protected]
Signed-off-by: Rafael Belchior [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.