chore(weaver): use specific fabric versions #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferlianne
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
jenniferlianne
changed the title
jenniferlianne
force-pushed
the
specify_fabric_ca_version
branch
from
d67aedb
to
b890aed
Compare
petermetz
approved these changes
Jul 23, 2024
jenniferlianne
changed the title
sandeepnRES
approved these changes
Jul 24, 2024
jenniferlianne
force-pushed
the
specify_fabric_ca_version
branch
from
b890aed
to
170fad9
Compare
While fabric setup for weaver tests downloads images specified in makefile, when the network is brought up the latest versions are pulled. Primary Change: - pass fabric versions from Makefile to network.sh, ensuring they are used Secondary Changes: network.sh: - allow specifying fabric ca version - set exit on error bash flag to avoid continuing if script is in error - re-write unsupported version tests to not not generate error - add rm -f to not generate error if file does not exist Signed-off-by: Jennifer Bell <[email protected]>
petermetz
force-pushed
the
specify_fabric_ca_version
branch
from
170fad9
to
ea5a3c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fabric setup for weaver tests downloads images specified in the Makefile, when the network is brought up the latest versions are pulled.
Primary Change:
Secondary Changes:
network.sh:
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.