Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(plugin-keychain-google-sm): migrate remaining tape tests to Jest #3425

Conversation

petermetz
Copy link
Contributor

  1. Also turned off tape test execution completely for the package in ci.yaml
    This would've been a no-op anyway just wasting resources since we have no
    tests left that need tape at all.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

1. Also turned off tape test execution completely for the package in ci.yaml
This would've been a no-op anyway just wasting resources since we have no
tests left that need tape at all.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-plugin-keychain-google-sm-jest-migrate-remaining-tests branch from 0d87f1b to fcc5b40 Compare July 24, 2024 18:37
@petermetz petermetz merged commit 49826f5 into hyperledger-cacti:main Jul 24, 2024
144 checks passed
@petermetz petermetz deleted the test-plugin-keychain-google-sm-jest-migrate-remaining-tests branch July 24, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants