fix: address CVE-2022-24434, GHSA-wm7h-9275-46v2 caused by dicer #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
jagpreetsinghsasan
approved these changes
Jul 18, 2024
outSH
approved these changes
Jul 18, 2024
The process for this fix was to: 1. `yarn why -R dicer` 2. Then examine the output of that and see which dependencies are using dicer indirectly (transient dependencies) 3. `yarn up multer --exact` 4. `yarn up express-openapi-validator --exact` 5. Profit, e.g. running `yarn why -R dicer` at this point shows that dicer has been eliminated from the dependency tree completely. https://github.com/hyperledger/cacti/security/dependabot/176 Weaknesses CWE-248 CVE ID CVE-2022-24434 GHSA ID GHSA-wm7h-9275-46v2 Also sneaking in a test case hot-fix for besu/deploy-contract/private-deploy-contract-from-json-cactus.test.ts where the error message assertion broke down after a change in error handling of the contract deployment endpoint. Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
fix-cve-2022-24434-dicer-ghsa-wm7h-9275-46v2
branch
from
ca0b1dc
to
0060c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process for this fix was to:
yarn why -R dicerdicer indirectly (transient dependencies)
yarn up multer --exactyarn up express-openapi-validator --exactyarn why -R dicerat this point shows thatdicer has been eliminated from the dependency tree completely.
https://github.com/hyperledger/cacti/security/dependabot/176
Weaknesses
CWE-248
CVE ID
CVE-2022-24434
GHSA ID
GHSA-wm7h-9275-46v2
Signed-off-by: Peter Somogyvari [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.