Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(common): jest migration of the key-converter utility test cases #3376

Conversation

petermetz
Copy link
Contributor

  1. The problem was that the database schema was defined in a way that was
    destroying timestamp information during insertion of records.
  2. Updating the schema to hold the timestamp information made the test pass.

More information about why it's recommended to store datetime data with
the TIMESTAMPTZ column type is explained by the author of the node-postgres
library which is an important part of the problem (it assumes local time
for columns that do not store the timestamp time zone).

https://node-postgres.com/features/types#date--timestamp--timestamptz

Fixes #3373

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@RafaelAPB RafaelAPB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job

@petermetz petermetz force-pushed the test-common-jest-migration-key-converter branch from 923d2fc to 7f1014d Compare July 5, 2024 21:15
1. Also upgraded the tsx dependency to the latest version.
2. We are planning on retiring ts-node in favor of tsx and this helps with
further triage of it.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-common-jest-migration-key-converter branch from 7f1014d to 315e345 Compare July 5, 2024 21:53
@petermetz petermetz disabled auto-merge July 5, 2024 22:01
@petermetz petermetz merged commit 315e345 into hyperledger-cacti:main Jul 5, 2024
138 of 150 checks passed
@petermetz petermetz deleted the test-common-jest-migration-key-converter branch July 5, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(plugin-persistence-ethereum): fix broken postgresql-db-client.test
3 participants