Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): refactor ActionLint job to use the official installer #3168

Conversation

petermetz
Copy link
Contributor

  1. Previously we just winged it with a bash script downloading another
    bash script to unzip the actionlint binaries.
  2. From now on we'll use the GitHub action from the marketplace which
    has a lot of configuration options exposed in a convenient way such as
    what type of warnings to ignore, what version of actionlint to install,
    etc.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. Previously we just winged it with a bash script downloading another
bash script to unzip the actionlint binaries.
2. From now on we'll use the GitHub action from the marketplace which
has a lot of configuration options exposed in a convenient way such as
what type of warnings to ignore, what version of actionlint to install,
etc.

Signed-off-by: Peter Somogyvari <[email protected]>
@outSH outSH force-pushed the ci-refactor-actionlint-github-workflow branch from f1a8bfe to f9d5e34 Compare April 4, 2024 10:10
@petermetz petermetz merged commit 7951784 into hyperledger-cacti:main Apr 4, 2024
130 of 141 checks passed
@petermetz petermetz deleted the ci-refactor-actionlint-github-workflow branch April 4, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants