Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ci.sh): fix Docker Compose presence check - migrate to sub-command #3167

Conversation

petermetz
Copy link
Contributor

  1. The old way to use docker compose was through the standalone binary
    docker-compose
  2. This was working for a while but now the auto-upgrades that we cannot
    seem to avoid have caught up with us and broke ci.sh in the GitHub action
    runners because the standalone binary is no longer available at all and
    therefore the migration must happen.
  3. Point 2 is just a theory but one that is considered to be very likely
    correct.
  4. It is to be seen if we'll have any other downstream issues such as the
    tests failing in other ways due to this underlying docker change.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryjones ryjones force-pushed the ci-fix-docker-compose-v2-presence-check branch from e7d1180 to bcf88da Compare April 2, 2024 18:52
1. The old way to use docker compose was through the standalone binary
`docker-compose`
2. This was working for a while but now the auto-upgrades that we cannot
seem to avoid have caught up with us and broke ci.sh in the GitHub action
runners because the standalone binary is no longer available at all and
therefore the migration must happen.
3. Point 2 is just a theory but one that is considered to be very likely
correct.
4. It is to be seen if we'll have any other downstream issues such as the
tests failing in other ways due to this underlying docker change.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the ci-fix-docker-compose-v2-presence-check branch from bcf88da to 8988ae4 Compare April 3, 2024 13:06
@petermetz petermetz merged commit f71c48e into hyperledger-cacti:main Apr 3, 2024
130 of 142 checks passed
@petermetz petermetz deleted the ci-fix-docker-compose-v2-presence-check branch April 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants