Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector-besu): migrate v21-get-balance test to Jest from tape #3064

Conversation

petermetz
Copy link
Contributor

Part of our ongoing effort to migrate the complete test suite from tape
to Jest.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@jagpreetsinghsasan
Copy link
Contributor

@ruzell22 tagging you so that you are aware of this change (will be merged soon so you will have to take a pull of this commit into your current code)

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Part of our ongoing effort to migrate the complete test suite from tape
to Jest.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-jest-migration-besu-v21-get-balance-test branch from 080f3b5 to a97db51 Compare March 7, 2024 07:21
@petermetz petermetz merged commit 1dfcf17 into hyperledger-cacti:main Mar 7, 2024
130 of 147 checks passed
@petermetz petermetz deleted the test-jest-migration-besu-v21-get-balance-test branch March 7, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants