feat(plugin-satp-hermes): replace IPFS dependency in SATP package #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreAugusto11
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
AndreAugusto11
force-pushed
the
fix-2984
branch
from
7971843 to
a5e9cdb
Compare
petermetz
requested changes
Feb 7, 2024
There was a problem hiding this comment.
@AndreAugusto11 Please rebase onto upstream/main and resolve the conflicts and then pass it back for review with the 're-request review' button.
FYI: I just merged the parent PR so you should end up with only a single commit on this one after the rebase.
AndreAugusto11
force-pushed
the
fix-2984
branch
from
a5e9cdb to
f44bad6
Compare
|
This PR/issue depends on:
|
AndreAugusto11
force-pushed
the
fix-2984
branch
5 times, most recently
from
0b29554 to
9033889
Compare
petermetz
reviewed
Feb 7, 2024
petermetz
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
@AndreAugusto11 LGTM, thank you very much for this contribution!
*implement the repository design pattern to make storage technology-agnostic * due to the deprecation of the ipfs package, this allows one to choose another storage * refactoring of the tests and the CBDC example that is based on the SATP * implement the remote log storage as a SQLite database * add post-build instruction to copy knex files to dist/ closes hyperledger-cacti#2984 depends on hyperledger-cacti#3006 Signed-off-by: André Augusto <[email protected]>
AndreAugusto11
force-pushed
the
fix-2984
branch
from
9033889 to
05f6b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2984
Signed-off-by: André Augusto [email protected]
depends on #3006