test(verifier-client): import ApiClient dynamically #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
|
This PR/issue depends on:
|
outSH
force-pushed
the
dynamic_verifier_client_imports_pr
branch
from
d7f3745
to
328edbe
Compare
- Import `ApiClient` from connector packages dynamically.
- Make `getVerifier` and `getValidatorApiClient` methods async to allow
use of dynamic ESM import in the future.
- Make connector dependencies of verifier-client optional. User must manually
install connector package they use to satisfy an optional peer dependency.
Connectors are still needed for building (i.e. devDependencies).
- Cleanup dependencies of verifier-client
- Use async verifier factory methods in tests and sample apps.
Depends on hyperledger-cacti#2904
Signed-off-by: Michal Bajer <[email protected]>
outSH
force-pushed
the
dynamic_verifier_client_imports_pr
branch
from
328edbe
to
e38aa0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApiClientfrom connector packages dynamically.getVerifierandgetValidatorApiClientmethods async to allowuse of dynamic ESM import in the future.
install connector package they use to satisfy an optional peer dependency.
Connectors are still needed for building (i.e. devDependencies).
Depends on #2904
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.