test(test-geth-ledger): add test for test-geth-ledger #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwat17
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
requested changes
Jul 31, 2023
There was a problem hiding this comment.
@rwat17 In addition to my above comment, could you please
- Rename the .json file so that it is an exact match to the
.solfile but with a different extenssion. - Obtain the JSON file by compiling it with the solidity VSCode extension which adds the
contractNameattribute (among other things) automatically as useful metadata that we sometimes use programmatically in test cases for reducing the number of magic strings the tests are depending on to function.
As an example of such .json file please take a look at this one: packages/cactus-plugin-htlc-eth-besu-erc20/src/main/solidity/contracts/HashedTimeLockContract.json
For the specific VSCode extension IDs please see the recommended extensions file under .vscode/extensions.json in there you'll see "juanblanco.solidity"
...s/cactus-test-geth-ledger/src/test/typescript/solidity/simple-token-contract/SimpleToken.sol
Outdated
Show resolved
Hide resolved
rwat17
force-pushed
the
geth-ledger-tests
branch
from
b58032d
to
6ef8f7f
Compare
petermetz
requested changes
Aug 8, 2023
packages/cactus-test-geth-ledger/src/main/typescript/geth-test-ledger.ts
Outdated
Show resolved
Hide resolved
packages/cactus-test-geth-ledger/src/test/typescript/integration/contractData.json
Outdated
Show resolved
Hide resolved
rwat17
force-pushed
the
geth-ledger-tests
branch
from
6ef8f7f
to
e9d6694
Compare
petermetz
reviewed
Aug 15, 2023
packages/cactus-test-geth-ledger/src/main/typescript/geth-test-ledger.ts
Outdated
Show resolved
Hide resolved
petermetz
reviewed
Aug 15, 2023
packages/cactus-test-geth-ledger/src/test/typescript/integration/geth-test-ledger.test.ts
Outdated
Show resolved
Hide resolved
petermetz
force-pushed
the
geth-ledger-tests
branch
from
e9d6694
to
696621b
Compare
petermetz
requested changes
Aug 15, 2023
There was a problem hiding this comment.
@rwat17 Please take a look at my commit and squash it so that there's (in the end) only one commit in the PR (after the parent PR has been merged)
Then pass it back for review!
rwat17
force-pushed
the
geth-ledger-tests
branch
2 times, most recently
from
4facda4
to
e9d6694
Compare
Signed-off-by: Michal Bajer <[email protected]>
Signed-off-by: Michal Bajer <[email protected]>
-add tests for geth-test-ledger -fix small errors in GethTestLedger class Closes: hyperledger-cacti#2579 Depends on: hyperledger-cacti#2577 Signed-off-by: Tomasz Awramski <[email protected]
rwat17
force-pushed
the
geth-ledger-tests
branch
from
e9d6694
to
e1b93b3
Compare
petermetz
requested changes
Aug 31, 2023
There was a problem hiding this comment.
@rwat17 Please
- Fix the DCO check
- Fix the dependency declaration syntax (the robot is pretty simple minded unfortunately and won't understand
Depends on: #2577onlyDepends on #2577(notice the colon difference) - this is important so that we don't accidentally merge the PR before the parent have been merged - Fix the
build-devcheck - When everything else is ready and the parent PR(s) have been merged please do the usual rebase + squash onto upstream/main
Marking it as a change request so we don't accidentally merge while the dependencies are not met. (once done with the chores above just pass it back for review)
|
I'm guessing this one has gone stale too since @rwat17 moved on, closing for now. We can re-open it anytime as usual. |
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Nov 24, 2023
- Add test suite for geth-test-ledger package. - Add new test suit to CI - It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements. Closes: hyperledger-cacti#2579 Co-authored-by: Tomasz Awramski <[email protected] Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Nov 24, 2023
- Add test suite for geth-test-ledger package. - Add new test suit to CI - It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements. Closes: hyperledger-cacti#2579 Co-authored-by: Tomasz Awramski <[email protected]> Signed-off-by: Michal Bajer <[email protected]>
5 tasks
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Dec 12, 2023
- Add test suite for geth-test-ledger package. - Add new test suit to CI - It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements. Closes: hyperledger-cacti#2579 Co-authored-by: Tomasz Awramski <[email protected]> Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Dec 18, 2023
- Add test suite for geth-test-ledger package. - Add new test suit to CI - It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements. Closes: hyperledger-cacti#2579 Co-authored-by: Tomasz Awramski <[email protected]> Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Dec 19, 2023
- Add test suite for geth-test-ledger package. - Add new test suit to CI - It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements. - Run codegen, update missing deps, sort package.json, fix type in socketio-test-setup-helpers, to fix some CI. Closes: hyperledger-cacti#2579 Co-authored-by: Tomasz Awramski <[email protected]> Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Dec 19, 2023
- Add test suite for geth-test-ledger package. - Add new test suit to CI - It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements. - Run codegen, update missing deps, sort package.json, fix type in socketio-test-setup-helpers, to fix some CI. Closes: hyperledger-cacti#2579 Co-authored-by: Tomasz Awramski <[email protected]> Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
that referenced
this pull request
Dec 19, 2023
- Add test suite for geth-test-ledger package. - Add new test suit to CI - It was initially proposed in #2588, I've added some cleanups and improvements. - Run codegen, update missing deps, sort package.json, fix type in socketio-test-setup-helpers, to fix some CI. Closes: #2579 Co-authored-by: Tomasz Awramski <[email protected]> Signed-off-by: Michal Bajer <[email protected]>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this pull request
Dec 21, 2023
- Add test suite for geth-test-ledger package. - Add new test suit to CI - It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements. - Run codegen, update missing deps, sort package.json, fix type in socketio-test-setup-helpers, to fix some CI. Closes: hyperledger-cacti#2579 Co-authored-by: Tomasz Awramski <[email protected]> Signed-off-by: Michal Bajer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2579
Depends on: #2577