build(codegen): fix OpenAPI TypeError: error.response.data.on is not a function #2528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and instead went with a direct download approach after having reverse
engineered the HTTP URLs that can be used for fetching the jars from
the maven repository.
that was serving HTTP 504 errors was not the download link but the
version validator link (e.g. a service that can tell us whether a
specific version of the OpenAPI generator jar file exists or not). So,
now that we just download exactly the versions of the .jars that we need
there is no request sent to that other service and the problem therefore
seems to have been solved.
because it no longer gets created to begin with due to the change from 1
issue with the OpenAPI generator jar files, but one can hope.
It is no longer doing bundle name validation nor the custom checks by
default and it also skips linting and codegen entirely which are now done
by separate jobs that can run in parallel. This should also reduce the
load we place on the public utility service that is hosting the .jar files
for the OpenAPI generator because this way the 40+ CI jobs that we have
at the moment won't each download a pair of >20 MB .jar files every time.
Fixes #2525
Signed-off-by: Peter Somogyvari [email protected]