-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iroha2-ledger): add Iroha V2 test ledger image and setup class #2140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petermetz @jagpreetsinghsasan @izuru0 Please upload this image to main ghcr so I can replace references in the commit :)
@outSH Sorry for the slow response again! I've just pushed the new image to the official repo, please use this tag in the code: ghcr.io/hyperledger/cactus-iroha2-all-in-one:2022-08-24-b4d59707b
- Add new Iroha V2 cactus connector. - Two OpenAPI endpoints are implemented: `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Added execution of Iroha2 tests to the CI. Additional notes: - Connector doesn't work well with cactus module system, the issue has been reported and described in README. PR is not merge-ready until this is fixed (the CI should fail now). - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
b4d5970
to
f2e8b60
Compare
- Add new Iroha V2 cactus connector. - Two OpenAPI endpoints are implemented: `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Added execution of Iroha2 tests to the CI. Additional notes: - Connector doesn't work well with cactus module system, the issue has been reported and described in README. PR is not merge-ready until this is fixed (the CI should fail now). - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
- Add new Iroha V2 cactus connector. - Two OpenAPI endpoints are implemented: `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Added execution of Iroha2 tests to the CI. Additional notes: - Connector doesn't work well with cactus module system, the issue has been reported and described in README. PR is not merge-ready until this is fixed (the CI should fail now). - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
- Add new Iroha V2 cactus connector. - Two OpenAPI endpoints are implemented: `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Added execution of Iroha2 tests to the CI. Additional notes: - Connector doesn't work well with cactus module system, the issue has been reported and described in README. PR is not merge-ready until this is fixed (the CI should fail now). - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
- Add new Iroha V2 cactus connector. - Two OpenAPI endpoints are implemented: `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Added execution of Iroha2 tests to the CI. Additional notes: - Connector doesn't work well with cactus module system, the issue has been reported and described in README. PR is not merge-ready until this is fixed (the CI should fail now). - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
f2e8b60
to
06770b6
Compare
@petermetz I've updated the |
@outSH I published the new image as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH Please pass the ball back with a "re-request review" once the image was updated and then we can merge!
ghcr.io/hyperledger/cactus-iroha2-all-in-one:2022-10-18-06770b6c
5f1dc0a
to
8f0c5e3
Compare
- Add new Iroha V2 cactus connector. - Two OpenAPI endpoints are implemented: `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Added execution of Iroha2 tests to the CI. Additional notes: - Connector doesn't work well with cactus module system, the issue has been reported and described in README. PR is not merge-ready until this is fixed (the CI should fail now). - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
8f0c5e3
to
66743a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH Thanks, LGTM
- Add a new test image for Iroha V2 (iroha2-all-in-one). It start a test ledger in single container, and also contains a proxy script for running iroha_client_cli. - Add the new image to the CI. - Add a new class for starting and interacting with Iroha V2 test ledger from typescript test - Iroha2TestLedger. - Add test for test setup class to ensure basic functions are working correctly. Relates to hyperledger-cacti#2138 Signed-off-by: Michal Bajer <[email protected]>
66743a2
to
47275e6
Compare
- Add new Iroha V2 cactus connector. - Add endpoints `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. Transaction can be awaited or can return immediately. - Add new endpoint `generate-transaction`, to create unsigned transactions that can be signed on the client side. - Add a function to iroha2-connector package to help signing iroha transactions on the client (BLP) side. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - Add new helper method for signing query payload on the client side. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Add test for complex scenario that involves creating new account and asset, and then transfering assets between two accounts. - Add test for parsing retrieved block data to find specific transaction hashes. - Added execution of Iroha2 tests to the CI. Additional notes: - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
- Add new Iroha V2 cactus connector. - Add endpoints `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. Transaction can be awaited or can return immediately. - Add new endpoint `generate-transaction`, to create unsigned transactions that can be signed on the client side. - Add a function to iroha2-connector package to help signing iroha transactions on the client (BLP) side. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - Add new helper method for signing query payload on the client side. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Add test for complex scenario that involves creating new account and asset, and then transfering assets between two accounts. - Add test for parsing retrieved block data to find specific transaction hashes. - Added execution of Iroha2 tests to the CI. Additional notes: - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
- Add new Iroha V2 cactus connector. - Add endpoints `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. Transaction can be awaited or can return immediately. - Add new endpoint `generate-transaction`, to create unsigned transactions that can be signed on the client side. - Add a function to iroha2-connector package to help signing iroha transactions on the client (BLP) side. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - Add new helper method for signing query payload on the client side. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Add test for complex scenario that involves creating new account and asset, and then transfering assets between two accounts. - Add test for parsing retrieved block data to find specific transaction hashes. - Added execution of Iroha2 tests to the CI. Additional notes: - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
- Add new Iroha V2 cactus connector. - Add endpoints `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. Transaction can be awaited or can return immediately. - Add new endpoint `generate-transaction`, to create unsigned transactions that can be signed on the client side. - Add a function to iroha2-connector package to help signing iroha transactions on the client (BLP) side. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - Add new helper method for signing query payload on the client side. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Add test for complex scenario that involves creating new account and asset, and then transfering assets between two accounts. - Add test for parsing retrieved block data to find specific transaction hashes. - Added execution of Iroha2 tests to the CI. Additional notes: - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
- Add new Iroha V2 cactus connector. - Add endpoints `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. Transaction can be awaited or can return immediately. - Add new endpoint `generate-transaction`, to create unsigned transactions that can be signed on the client side. - Add a function to iroha2-connector package to help signing iroha transactions on the client (BLP) side. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - Add new helper method for signing query payload on the client side. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Add test for complex scenario that involves creating new account and asset, and then transfering assets between two accounts. - Add test for parsing retrieved block data to find specific transaction hashes. - Added execution of Iroha2 tests to the CI. Additional notes: - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
- Add new Iroha V2 cactus connector. - Add endpoints `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. Transaction can be awaited or can return immediately. - Add new endpoint `generate-transaction`, to create unsigned transactions that can be signed on the client side. - Add a function to iroha2-connector package to help signing iroha transactions on the client (BLP) side. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - Add new helper method for signing query payload on the client side. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Add test for complex scenario that involves creating new account and asset, and then transfering assets between two accounts. - Add test for parsing retrieved block data to find specific transaction hashes. - Added execution of Iroha2 tests to the CI. Additional notes: - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
- Add new Iroha V2 cactus connector. - Add endpoints `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. Transaction can be awaited or can return immediately. - Add new endpoint `generate-transaction`, to create unsigned transactions that can be signed on the client side. - Add a function to iroha2-connector package to help signing iroha transactions on the client (BLP) side. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - Add new helper method for signing query payload on the client side. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Add test for complex scenario that involves creating new account and asset, and then transfering assets between two accounts. - Add test for parsing retrieved block data to find specific transaction hashes. - Added execution of Iroha2 tests to the CI. Additional notes: - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
- Add new Iroha V2 cactus connector. - Add endpoints `transact` and `query`. Both endpoints support critical subset of instructions and queries supported by the upstream javascript iroha sdk. Transaction can be awaited or can return immediately. - Add new endpoint `generate-transaction`, to create unsigned transactions that can be signed on the client side. - Add a function to iroha2-connector package to help signing iroha transactions on the client (BLP) side. - One SocketIO endpoint can be used to monitor new blocks from the ledger. - Add new helper method for signing query payload on the client side. - New connector can be used through a verifier-client interface. - All added functions are tested in functional test suites and documented. - Add test for complex scenario that involves creating new account and asset, and then transfering assets between two accounts. - Add test for parsing retrieved block data to find specific transaction hashes. - Added execution of Iroha2 tests to the CI. Additional notes: - Iroha V2 javascript packages are not available on official npm yet, had to include `.npmrc` with private npm address. I'm not sure if there's ETA of delivering these through NPM, so it might be necessary to commit it after all. Closes hyperledger-cacti#2138 Depends on hyperledger-cacti#2140 Signed-off-by: Michal Bajer <[email protected]>
and also contains a proxy script for running iroha_client_cli.
from typescript test - Iroha2TestLedger.
Relates to #2138
Signed-off-by: Michal Bajer [email protected]