fix: part 2 of lint warnings resolved for batch 7/26 #1356 : Commit to be reviewed

[akankshadixit]

style(common): fix batch 7/26 of linter warnings

Changes made:

• Fixed lint warnings associated with any-type for truthyness and nonBlankString checking
• Fixed lint warnings associated with type-aliases in logger
• Fixed lint warnings associated with non-any type in getAllMethodNames and getAllFieldNames
• Fixed lint errors associated with unexpected any for private-public keypairs
• Added an isRecord user-defined type guard in the common package that
  can narrow unknown types into Record<string, unknown>

Fixes #1356

Co-authored-by: Peter Somogyvari [email protected]

Signed-off-by: akankshadixit [email protected]
Signed-off-by: Peter Somogyvari [email protected]

[jagpreetsinghsasan]

The changes looks fine, just a squash merge of the commits required.

[petermetz]

@akankshadixit LGTM, thank you!

Some advice on the admin chores to speed things up next time: If a reviewer requested changes and then you addressed them (like you did here) then it helps if you then hit the little circular arrows button next to their name (in this case Jagpreet) which is called the "re-request review" button which will send them a ping to come back and check on the changes you've made in response to their change request. Without this it doesn't actually pop up on their feed as the PR needing review again.

[akankshadixit]

Hi @petermetz,

Thank you. I will ensure this in future.

[petermetz]

Hi @petermetz,

Thank you. I will ensure this in future.

@akankshadixit No worries at all, it's not a big deal either way, I'm just letting you know for future reference. :-)

[petermetz]

@akankshadixit The build seems to be broken now, please double check if it works locally and then let's go from there.

I'm not sure if you have access to the CI Logs or not but the build-dev check failed with this:

5:41:00 AM - Project 'packages/cactus-common/tsconfig.json' is out of date because output file 'packages/cactus-common/dist/lib/main/typescript/bools.js' does not exist
5:41:00 AM - Building project '/home/runner/work/cactus/cactus/packages/cactus-common/tsconfig.json'...
Error: packages/cactus-common/src/test/typescript/unit/objects/get-all-method-names.test.ts(8,49): error TS2345: Argument of type 'A' is not assignable to parameter of type 'Record<string, unknown>'.
  Index signature is missing in type 'A'.
5:41:04 AM - Project 'packages/cactus-core-api/tsconfig.json' can't be built because its dependency 'packages/cactus-common/tsconfig.json' has errors

[petermetz]

^^

[petermetz]

@akankshadixit LGTM now with the additions I made just now it does not have to be a breaking change and we are good to go!