feat(keychain-google-sm): complete request handler and endpoints #1097

[twiggins120]

Fixes #1097

Depends on #1196
Depends on #1406

[codecov-commenter]

Codecov Report

Merging #1188 (bdeeffa) into main (01a5eb4) will increase coverage by 0.80%.
The diff coverage is 83.50%.

@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
+ Coverage   70.53%   71.33%   +0.80%     
==========================================
  Files         302      306       +4     
  Lines       10902    11081     +179     
  Branches     1332     1346      +14     
==========================================
+ Hits         7690     7905     +215     
+ Misses       2508     2452      -56     
- Partials      704      724      +20     

Impacted Files	Coverage Δ
.../typescript/mock/plugin-keychain-google-sm-mock.ts	73.68% <0.00%> (ø)
...ript/webservices/get-keychain-entry-endpoint-v1.ts	80.55% <80.55%> (ø)
...m/src/main/typescript/plugin-keychain-google-sm.ts	81.48% <83.33%> (+19.48%)	⬆️
...pescript/generated/openapi/typescript-axios/api.ts	84.09% <84.00%> (+70.09%)	⬆️
...t/webservices/delete-keychain-entry-endpoint-v1.ts	84.84% <84.84%> (ø)
...ript/webservices/set-keychain-entry-endpoint-v1.ts	84.84% <84.84%> (ø)
...ript/webservices/has-keychain-entry-endpoint-v1.ts	85.71% <85.71%> (ø)
...escript/generated/openapi/typescript-axios/base.ts	58.33% <0.00%> (+16.66%)	⬆️
...-sm/src/main/typescript/plugin-factory-keychain.ts	83.33% <0.00%> (+16.66%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a5eb4...bdeeffa. Read the comment docs.

[petermetz]

@twiggins120

A few nits:

1. Please squash the left-over changes from Jagpreet's commit together with your own commit (you can use fixup so that it disappears the commit message from Jagpreet's commit)
2. delete the package-lock.json, we don't need it since we migrated over to yarn
3. Remove the package specific dependency from the root package .json file
4. Make sure you coordinate with Wen about the additional PR that Wen is preparing to make the necessary changes to the core-api package's openapi.json file
5. Once that PR from Wen is open from point 4), please make sure to mark this PR as a dependent on that one.
6. Then once that PR gets merged this'll need to be updated to use the newly published core-api openapi.json file's link (I can show how that's done later)

cc: @ty-lazar @Leeyoungone

[decommissioned-account]

@twiggins120

A few nits:

1. Please squash the left-over changes from Jagpreet's commit together with your own commit (you can use fixup so that it disappears the commit message from Jagpreet's commit)
2. delete the package-lock.json, we don't need it since we migrated over to yarn
3. Remove the package specific dependency from the root package .json file
4. Make sure you coordinate with Wen about the additional PR that Wen is preparing to make the necessary changes to the core-api package's openapi.json file
5. Once that PR from Wen is open from point 4), please make sure to mark this PR as a dependent on that one.
6. Then once that PR gets merged this'll need to be updated to use the newly published core-api openapi.json file's link (I can show how that's done later)

cc: @ty-lazar @Leeyoungone

Addressed points 1, 2, and 3

[Leeyoungone]

Hello again! It seems like I can't press the button to request review because the requested changes haven't been addressed? This time I'm not sure what they are but I'm going to go ahead and ping you for review @petermetz. Sorry about having to ask for reviews this way.

[Leeyoungone]

Just finished rebasing and changed relative paths! @petermetz

[petermetz]

@Leeyoungone packages/cactus-core-api/src/main/json/openapi.json has changes in it, those should to the a parent PR and then once that's merged+tagged those changes can be used by this PR

[petermetz]

LGTM

[github-actions]

🎉 Great news! Looks like all the dependencies have been resolved:

• refactor(core-api): make schema names consistent in openapi spec #1196
• fix(webpack): prod build chokes on upgraded ssh2 binaries #1405 #1406

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!