Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): fix commit parity check is running outside of PRs #3515

Closed
petermetz opened this issue Sep 4, 2024 · 0 comments · Fixed by #3535
Closed

ci(github): fix commit parity check is running outside of PRs #3515

petermetz opened this issue Sep 4, 2024 · 0 comments · Fixed by #3535
Assignees
@jagpreetsinghsasan
Labels
Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Milestone
v2.0.0

Comments

@petermetz
Copy link
Contributor

Description

The commit parity check does not make sense to be running on the main branch because there is no pull request description to compare the texts to in that context.

Right now it is configured to run on the main branch but then it just crashes of course.

Attaching logs:
2024-09-04T21-17-10-commit-parity-check-main-branch.crash.log

Acceptance Criteria

  1. Commit parity check does not run at all on main branch saving resources and also not cluttering with false-negatives.
@petermetz petermetz added the Tests Anything related to tests be that automatic or manual, integration or unit, etc. label Sep 4, 2024
@petermetz petermetz added this to the v2.0.0 milestone Sep 4, 2024
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Sep 10, 2024
ci(github): fix commit parity runing outside PR
65f2731 
    Primary Changes
    ---------------
    1. Updated the workflow to run only on Pull Requests

Fixes hyperledger-cacti#3515

Signed-off-by: jagpreetsinghsasan <[email protected]>
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Sep 10, 2024
ci(github): fix commit parity running outside PR
a0b41c6 
    Primary Changes
    ---------------
    1. Updated the workflow to run only on Pull Requests

Fixes hyperledger-cacti#3515

Signed-off-by: jagpreetsinghsasan <[email protected]>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Sep 10, 2024
Merged
5 tasks
petermetz pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Sep 10, 2024
@petermetz
ci(github): fix commit parity running outside PR
1552e6c 
    Primary Changes
    ---------------
    1. Updated the workflow to run only on Pull Requests

Fixes hyperledger-cacti#3515

Signed-off-by: jagpreetsinghsasan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

ci(github): fix commit parity running outside PR jagpreetsinghsasan/cactus
2 participants
@petermetz @jagpreetsinghsasan