Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(tools/docker): stop compiling Iroha as part of the all-in-one image build #2524

Closed
petermetz opened this issue Jun 28, 2023 · 0 comments · Fixed by #2556
Closed

ci(tools/docker): stop compiling Iroha as part of the all-in-one image build #2524

petermetz opened this issue Jun 28, 2023 · 0 comments · Fixed by #2556
Assignees
@petermetz
Labels
Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Iroha Bugs/features related to the Iroha ledger connector plugin P2 Priority 2: High Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Tests Anything related to tests be that automatic or manual, integration or unit, etc. Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.

Comments

@petermetz
Copy link
Contributor

We should try and use the base-image that the Iroha maintainers publish.
This way our image could be built much faster and this would in turn make the
performance of the CI much better.
@petermetz petermetz added the Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. label Jun 28, 2023
@petermetz petermetz self-assigned this Jun 28, 2023
@petermetz petermetz added good-first-issue Good for newcomers Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc. good-first-issue-400-expert Iroha Bugs/features related to the Iroha ledger connector plugin Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Tests Anything related to tests be that automatic or manual, integration or unit, etc. P2 Priority 2: High Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Jun 28, 2023
petermetz added a commit to petermetz/cacti that referenced this issue Jul 17, 2023
@petermetz
ci(tools/docker): stop compiling Iroha as part of the all-in-one imag…
3d70107 
…e build

1. Upgraded the Iroha AIO image to use v1.4.0-patch-3
2. The new Iroha version now supports configuraton via ENV variables
3. Because of 2) we don't need to apply config file changes in the
entrypoint script of the container anymore, yay.
4. The new image uses the iroha release image as the base and  it
does NOT recompile the entire project which makes the build
orders of magnitude faster, wasting much less CI time/resources.
5. Exposed the healthcheck port for through the IrohaTestLedger class
so the other improvement we'll be able to do after this is to phase out
the hacky python script that does the healthcheck at the moment if
the new built-in healthcheck endpoint does actually work fine.
6. Migrated all the test cases to the new image version.

Fixes hyperledger-cacti#2524

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz mentioned this issue Jul 17, 2023
Merged
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
@petermetz @sandeepnRES
ci(tools/docker): stop compiling Iroha as part of the all-in-one imag…
0662cf1 
…e build

1. Upgraded the Iroha AIO image to use v1.4.0-patch-3
2. The new Iroha version now supports configuraton via ENV variables
3. Because of 2) we don't need to apply config file changes in the
entrypoint script of the container anymore, yay.
4. The new image uses the iroha release image as the base and  it
does NOT recompile the entire project which makes the build
orders of magnitude faster, wasting much less CI time/resources.
5. Exposed the healthcheck port for through the IrohaTestLedger class
so the other improvement we'll be able to do after this is to phase out
the hacky python script that does the healthcheck at the moment if
the new built-in healthcheck endpoint does actually work fine.
6. Migrated all the test cases to the new image version.

Fixes hyperledger-cacti#2524

Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) good-first-issue Good for newcomers good-first-issue-400-expert Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Iroha Bugs/features related to the Iroha ledger connector plugin P2 Priority 2: High Performance Everything related to how fast/efficient the software or it's tooling (e.g. build) is. Tests Anything related to tests be that automatic or manual, integration or unit, etc. Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(tools/docker): stop compiling Iroha as part of the all-in-one image build petermetz/cacti
1 participant
@petermetz