Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix path of and name of RIFUtil.test.ts #1515

Closed
petermetz opened this issue Nov 5, 2021 · 1 comment · Fixed by #2442
Closed

test: fix path of and name of RIFUtil.test.ts #1515

petermetz opened this issue Nov 5, 2021 · 1 comment · Fixed by #2442
Labels
bug Something isn't working Developer_Experience P5 Priority 5: Lowest Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@petermetz
Copy link
Contributor

petermetz commented Nov 5, 2021 •
edited
Loading

See the containing epic for more context and the scope of packages that are being affected: #1497

  1. Ensure the test is under the unit test directory to conform to the package structure expected by the CI. Current path: /packages/cactus-cmd-socketio-server/src/main/typescript/routing-interface/util/RIFUtil.test.ts
  2. Rename using the camel-case convention to construct the new filename.

2023-06-14 Correction: I meant to say 'kebab-case' not camelCase
@petermetz petermetz added bug Something isn't working ConnectionChain Developer_Experience P5 Priority 5: Lowest Tests Anything related to tests be that automatic or manual, integration or unit, etc. labels Nov 5, 2021
arnabnandikgp added a commit to arnabnandikgp/cacti that referenced this issue Jun 3, 2023
@arnabnandikgp
test: fix path of and name of RIFUtil.test.ts hyperledger-cacti#1515
eaecf14 
Signed-off-by: Arnab Nandi <[email protected]>
@arnabnandikgp arnabnandikgp mentioned this issue Jun 3, 2023
Merged
@petermetz
Copy link
Contributor Author

petermetz commented Jun 14, 2023 •
edited
Loading

@arnabnandikgp Correction: I meant to say 'kebab-case' not camelCase, apologies!

petermetz pushed a commit to arnabnandikgp/cacti that referenced this issue Jun 14, 2023
@arnabnandikgp @petermetz
test: fix path of and name of RIFUtil.test.ts hyperledger-cacti#1515
691f634 
Peter: Also modified the import path based on the location of the
test file now being different.

Fixes hyperledger-cacti#1515

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: Arnab Nandi <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz pushed a commit to arnabnandikgp/cacti that referenced this issue Jun 16, 2023
@arnabnandikgp @petermetz
test: fix path of and name of RIFUtil.test.ts hyperledger-cacti#1515
59946f2 
Peter: Also modified the import path based on the location of the
test file now being different.

Fixes hyperledger-cacti#1515

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: Arnab Nandi <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
petermetz pushed a commit that referenced this issue Jun 16, 2023
@arnabnandikgp @petermetz
test: fix path of and name of RIFUtil.test.ts #1515
6603543 
Peter: Also modified the import path based on the location of the
test file now being different.

Fixes #1515

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: Arnab Nandi <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
barnapa pushed a commit to barnapa/cacti that referenced this issue Jun 22, 2023
@arnabnandikgp @barnapa
test: fix path of and name of RIFUtil.test.ts hyperledger-cacti#1515
f095491 
Peter: Also modified the import path based on the location of the
test file now being different.

Fixes hyperledger-cacti#1515

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: Arnab Nandi <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this issue Dec 21, 2023
@arnabnandikgp @sandeepnRES
test: fix path of and name of RIFUtil.test.ts hyperledger-cacti#1515
2a54940 
Peter: Also modified the import path based on the location of the
test file now being different.

Fixes hyperledger-cacti#1515

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: Arnab Nandi <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Developer_Experience P5 Priority 5: Lowest Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix path of and name of RIFUtil.test.ts #1515 arnabnandikgp/cacti
1 participant
@petermetz