-
Notifications
You must be signed in to change notification settings - Fork 286
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(cactus-plugin-ledger-connector-ethereum): update web3js to 4.X
- Update web3js packages from 1.10 to 4.0.3 in `cactus-plugin-ledger-connector-ethereum` and
`cactus-test-plugin-ledger-connector-ethereum`. This allows interacting
with most recent geth nodes.
- Refactor all ethereum tests. Most of the test cases were duplicated multiple times
(between different quorum ledger versions test and deployment methods). I've removed all this
duplication while maintaining similar level of test coverage.
New tests use Geth test ledger instead of Quorum one.
- Add web3js type conversions methods to minimize impact of poor dynamic typing
in this early release of 4.X.
- Update API. In 4.X all numeric responses has been converted to BigNum.
To keep up with this some fields has been changed to string instead of number when necessary.
Add some missing fields as well.
- Add `estimateMaxFeePerGas` method for estimating current transaction cost.
- Fix invalid `runTransact` response type.
- Add test script for checking integration with Alchemy that must be executed manually
(it's excluded from CI at the moment) - `geth-alchemy-integration-manual-check.test`.
Instructions on how to run it has been added to package README.
Closes: #2580
Depends on #2535
Depends on #2578
Co-authored-by: Peter Somogyvari <[email protected]>
Signed-off-by: Michal Bajer <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>- Loading branch information
Showing
51 changed files
with
2,007 additions
and
6,205 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -134,11 +134,11 @@ jobs: | |
| uses: actions/[email protected] | ||
| with: | ||
| script: | | ||
| const failMsg = "yarn codegen script produced version control " + | ||
| "side-effects: source files have been changed by it that are " + | ||
| "otherwise are under version control. " + | ||
| "This means (99% of the time) that you need to run the " + | ||
| "yarn codegen script locally and then include the changes it " + | ||
| const failMsg = "yarn codegen script produced version control " + | ||
| "side-effects: source files have been changed by it that are " + | ||
| "otherwise are under version control. " + | ||
| "This means (99% of the time) that you need to run the " + | ||
| "yarn codegen script locally and then include the changes it " + | ||
| "makes in your own commit when submitting your pull request."; | ||
| core.setFailed(failMsg) | ||
|
|
@@ -1325,9 +1325,7 @@ jobs: | |
| FULL_BUILD_DISABLED: true | ||
| JEST_TEST_PATTERN: packages/cactus-plugin-ledger-connector-ethereum/src/test/typescript/(unit|integration|benchmark)/.*/*.test.ts | ||
| JEST_TEST_RUNNER_DISABLED: false | ||
| TAPE_TEST_PATTERN: >- | ||
| --files={./packages/cactus-plugin-ledger-connector-ethereum/src/test/typescript/integration/plugin-ledger-connector-ethereum/deploy-contract/openapi/openapi-validation-no-keychain.test.ts,./packages/cactus-plugin-ledger-connector-ethereum/src/test/typescript/integration/plugin-ledger-connector-ethereum/deploy-contract/openapi/openapi-validation.test.ts,./packages/cactus-plugin-ledger-connector-ethereum/src/test/typescript/integration/plugin-ledger-connector-ethereum/deploy-contract/v2.3.0-deploy-contract-from-json-json-object-endpoints.test.ts,./packages/cactus-plugin-ledger-connector-ethereum/src/test/typescript/integration/plugin-ledger-connector-ethereum/deploy-contract/v2.3.0-deploy-contract-from-json-json-object.test.ts,./packages/cactus-plugin-ledger-connector-ethereum/src/test/typescript/integration/plugin-ledger-connector-ethereum/deploy-contract/v2.3.0-invoke-contract-json-object-endpoints.test.ts,./packages/cactus-plugin-ledger-connector-ethereum/src/test/typescript/integration/plugin-ledger-connector-ethereum/deploy-contract/v2.3.0-invoke-contract-json-object.test.ts,./packages/cactus-plugin-ledger-connector-ethereum/src/test/typescript/integration/plugin-ledger-connector-ethereum/deploy-contract/v21.4.1-deploy-contract-from-json-json-object-endpoints.test.ts,./packages/cactus-plugin-ledger-connector-ethereum/src/test/typescript/integration/plugin-ledger-connector-ethereum/deploy-contract/v21.4.1-deploy-contract-from-json-json-object.test.ts,./packages/cactus-plugin-ledger-connector-ethereum/src/test/typescript/integration/plugin-ledger-connector-ethereum/deploy-contract/v21.4.1-invoke-contract-json-object-endpoints.test.ts,./packages/cactus-plugin-ledger-connector-ethereum/src/test/typescript/integration/plugin-ledger-connector-ethereum/deploy-contract/v21.4.1-invoke-contract-json-object.test.ts} | ||
| TAPE_TEST_RUNNER_DISABLED: false | ||
| TAPE_TEST_RUNNER_DISABLED: true | ||
| needs: build-dev | ||
| runs-on: ubuntu-20.04 | ||
| steps: | ||
|
|
@@ -1336,17 +1334,14 @@ jobs: | |
| with: | ||
| node-version: v16.14.2 | ||
| - uses: actions/[email protected] | ||
| - id: yarn-cache-dir-path | ||
| name: Get yarn cache directory path | ||
| run: echo "::set-output name=dir::$(yarn cache dir)" | ||
| - id: yarn-cache | ||
| name: Restore Yarn Cache | ||
| uses: actions/cache@v3.0.4 | ||
| uses: actions/cache@v3.3.1 | ||
| with: | ||
| key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
| path: ${{ steps.yarn-cache-dir-path.outputs.dir }} | ||
| key: ${{ runner.os }}-yarn-${{ hashFiles('./yarn.lock') }} | ||
| path: ./.yarn/ | ||
| restore-keys: | | ||
| ${{ runner.os }}-yarn- | ||
| ${{ runner.os }}-yarn-${{ hashFiles('./yarn.lock') }} | ||
| - run: ./tools/ci.sh | ||
| cactus-plugin-ledger-connector-quorum: | ||
| continue-on-error: false | ||
|
|
@@ -1637,13 +1632,13 @@ jobs: | |
| restore-keys: | | ||
| ${{ runner.os }}-yarn-${{ hashFiles('./yarn.lock') }} | ||
| - run: ./tools/ci.sh | ||
|
|
||
| - name: Install Foundry | ||
| uses: foundry-rs/foundry-toolchain@v1 | ||
|
|
||
| - name: Run solidity tests | ||
| run: cd packages/cactus-plugin-htlc-eth-besu && forge test -vvvvv | ||
|
|
||
| cactus-test-plugin-htlc-eth-besu-erc20: | ||
| continue-on-error: false | ||
| env: | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.