Skip to content

Commit

Permalink
build(nodejs): bump minimal nodejs and npm versions
Browse files Browse the repository at this point in the history
- Add script `tools/bump-package-engines.ts` to update minimal node and npm
    versions in all cacti packages.
- Set minimal node to 18 and npm to 8 in all cacti packages.
- Add env variable `NODEJS_VERSION` in CI scripts to centralize nodejs setup.
- Change default nodejs in CI to v18.18.2
- Minor formatting fixes - sorted package.json, removed whitespaces.
- Use socket.io-client-fixed-types in sawtooth connector to fix
    ESM import error
- Change node-fetch to 2.7.0 (still supported) in ubiqity connector to fix
    ESM import error
- Use explicit 127.0.0.1 instead of localhost in many source files. NodeJS 18
    prefers ipv6 over ipv4 and that caused some troubles when localhost
    was used.
- Run codegen to update file structure.
- Replace ts-ignore with ts-expect-error and add description to fix
    es-lint errors. Fix formatting issues found by the linter.

Signed-off-by: Michal Bajer <[email protected]>
  • Loading branch information
outSH authored and petermetz committed Dec 11, 2023
1 parent 66f65a8 commit 3371772
Show file tree
Hide file tree
Showing 231 changed files with 1,107 additions and 913 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/.dast-nuclei-cmd-api-server.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: DAST_Scan_Nuclei

env:
NODEJS_VERSION: v18.18.2

on:
push:
branches: [main, dev]
Expand All @@ -23,10 +26,10 @@ jobs:
indy-cli \
&& sudo rm -f /etc/apt/sources.list.d/sovrin.list*
- name: Set up NodeJS v16.9.1
- name: Set up NodeJS ${{ env.NODEJS_VERSION }}
uses: actions/[email protected]
with:
node-version: v16.9.1
node-version: ${{ env.NODEJS_VERSION }}

- name: Install jq
run: sudo apt update && sudo apt install -y jq
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/all-nodejs-packages-publish.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: all-nodejs-packages-publish

env:
NODEJS_VERSION: v18.18.2

on:
push:

Expand All @@ -21,7 +24,7 @@ jobs:
- uses: actions/[email protected]
with:
always-auth: true
node-version: '16.14.2'
node-version: ${{ env.NODEJS_VERSION }}
registry-url: 'https://registry.npmjs.org'
- name: ./tools/ci.sh
run: ./tools/ci.sh
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/cacti-dev-container-vscode-publish.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: connector-fabric-publish

env:
NODEJS_VERSION: v20.3.0

on:
push:
# Publish `v1.2.3` tags as releases.
Expand Down Expand Up @@ -27,10 +30,10 @@ jobs:
contents: read

steps:
- name: Use Node.js v20.3.0
- name: Use Node.js ${{ env.NODEJS_VERSION }}
uses: actions/[email protected]
with:
node-version: v20.3.0
node-version: ${{ env.NODEJS_VERSION }}

- uses: actions/[email protected]

Expand Down
Loading

0 comments on commit 3371772

Please sign in to comment.