This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Update Go sdk to comply with golang/protobuf update #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The golang/protobuf dependency update on 4/30 forces users to use keyed
literals (e.g., foopb.Message{Name: "Golang", Age: 8} as opposed to
foopb.Message{"Golang", 8}). There were a few examples of the latter
that had to be updated.
Signed-off-by: Darian Plumb <[email protected]>
dplumb94
requested review from
grkvlt,
peterschwarz,
vaporos,
boydjohnson,
jsmitchell,
rberg2,
aludvik and
nick-drozd
peterschwarz
approved these changes
May 1, 2018
aludvik
approved these changes
May 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golang/protobuf dependency update on 4/30 forces users to use keyed literals (e.g.,
foopb.Message{Name: "Golang", Age: 8}as opposed tofoopb.Message{"Golang", 8}). There were a few examples of the latter that had to be updated.https://groups.google.com/forum/#!topic/protobuf/N-elvFu4dFM
golang/protobuf#591
Signed-off-by: Darian Plumb [email protected]