Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

fix ordering of attributes being used before being introduced #2432

Closed

Conversation

AxelNennker
Copy link
Contributor

Signed-off-by: Axel Nennker [email protected]

The compiler was complaining about the following:

warning: derive helper attribute is used before it is introduced
--> src/services/pool/types.rs:357:3
|
357 | #[serde(tag = "op")]
| ^^^^^
358 | #[derive(Serialize, Deserialize, Debug)]
| --------- the attribute is introduced here
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79202 rust-lang/rust#79202

This PR reorders the two code lines so that the attribute is used after being introduced

@AxelNennker
Copy link
Contributor Author

I think the build failure is not due to this PR.

@WadeBarnes
Copy link
Contributor

@AxelNennker, you are correct, it is not. A fix for the build issues has been implemented (#2470), which should have also addressed the changes you made here. Please confirm and close the PR is this is the case.

@WadeBarnes WadeBarnes added the wont-address-project-depreciated This Issue or PR will not be addressed. The project has been depreciated. label Oct 24, 2023
@ryjones ryjones closed this Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wont-address-project-depreciated This Issue or PR will not be addressed. The project has been depreciated.
Development

Successfully merging this pull request may close these issues.

4 participants