This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
UP-42: Add API calls for frozen ledgers #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Denishchenko <[email protected]>
Signed-off-by: Anton Denishchenko <[email protected]>
Signed-off-by: Anton Denishchenko <[email protected]>
Signed-off-by: Anton Denishchenko <[email protected]>
Signed-off-by: Anton Denishchenko <[email protected]>
|
(ci) test this please |
Signed-off-by: Anton Denishchenko <[email protected]>
Signed-off-by: Anton Denishchenko <[email protected]>
Signed-off-by: Anton Denishchenko <[email protected]>
Signed-off-by: Anton Denishchenko <[email protected]>
Toktar
reviewed
Feb 1, 2021
There was a problem hiding this comment.
Please, add
- checks for the integration test for GET_FROZEN_LEDGERS
- unit tests to services/ledger/mod.rs
- unit tests to ledger service, cli(optional), wrappers(optional) for LEDGERS_FREEZE with sending
-- an empty list of ledgers ids
-- a list of ledgers ids in a string format
-- request without ledgers' list
-- request with None ledgers' list - test for GET_FROZEN_LEDGERS with getting empty map
cli/src/commands/ledger.rs
Outdated
Comment on lines
2100
to
2101
| let key = kv.0; | ||
| let value = kv.1; |
There was a problem hiding this comment.
Could you please rename them to ledger_id and ledger_info?
The next variable ledger_id can be renamed to json_ledger_id.
Toktar
reviewed
Feb 1, 2021
Toktar
changed the title
Toktar
changed the title
Signed-off-by: Anton Denishchenko <[email protected]>
Signed-off-by: Anton Denishchenko <[email protected]>
Toktar
reviewed
Feb 8, 2021
Signed-off-by: Anton Denishchenko <[email protected]>
Toktar
approved these changes
Feb 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anton Denishchenko [email protected]