This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: MySQL implementation of interface methods needed by Aries agent #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 86.95% 82.55% -4.41%
==========================================
Files 3 1 -2
Lines 598 235 -363
==========================================
- Hits 520 194 -326
+ Misses 47 21 -26
+ Partials 31 20 -11
Continue to review full report at Codecov.
|
DRK3
force-pushed
the
MySQLQueryMethod
branch
3 times, most recently
from
06e3c75
to
565fd73
Compare
- Implementation of various provider and stores methods that are needed in order for a MySQL provider to work in an Aries agent. - The implementation introduced in this commit is functional but not optimal - it doesn't take advantage of the proper built-in MySQL indexing functionality. This is left as a ToDo. Signed-off-by: Derek Trider <[email protected]>
DRK3
force-pushed
the
MySQLQueryMethod
branch
from
565fd73
to
415d27b
Compare
fqutishat
approved these changes
Mar 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Trider [email protected]