chore(test): Move integration test for tonic-web to tests directory #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Sep 9, 2024
tests/integration_web/Cargo.toml
Outdated
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| authors = ["Juan Alvarez <[email protected]>"] | |||
| edition = "2021" | |||
| name = "integration" | |||
| name = "integration_web" | |||
There was a problem hiding this comment.
I'm not a fan of the integration_ prefix here. Everything in /tests is an integration test by default, and adding the prefix here doesn't seem useful -- just call it /tests/web?
There was a problem hiding this comment.
Changed to /tests/web.
tottoto
force-pushed
the
move-integration-test-for-web-to-tests-directory
branch
from
9d41c27
to
3fd64f0
Compare
tottoto
deleted the
move-integration-test-for-web-to-tests-directory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves integration test for
tonic-webto tests directory where other integration tests are located.